Bug 1969773

Summary:	[4.8.0] Empty cluster name on handleEnsureISOErrors log after applying InfraEnv.yaml
Product:	OpenShift Container Platform	Reporter:	Michael Filanov <mfilanov>
Component:	assisted-installer	Assignee:	Elior Erez <eerez>
assisted-installer sub component:	Deployment Operator	QA Contact:	bjacot
Status:	CLOSED ERRATA	Docs Contact:
Severity:	low
Priority:	low	CC:	alazar, aos-bugs, eerez, mfilanov, nshidlin
Version:	4.8	Keywords:	Triaged
Target Milestone:	---
Target Release:	4.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	KNI-EDGE-JUKE-4.8 AI-Team-Hive
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:	1969766	Environment:
Last Closed:	2021-07-27 23:12:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1969766
Bug Blocks:

Description Michael Filanov 2021-06-09 08:57:12 UTC

+++ This bug was initially created as a clone of Bug #1969766 +++

Description of problem:

After applying InfraEnv.yaml the cluster name is empty on the log message:
`time="2021-06-08T16:50:21Z" level=info msg="Image myinfraenv being prepared for cluster " func="github.com/openshift/assisted-service/internal/controller/controllers.(*InfraEnvReconciler).handleEnsureISOErrors" file="/go/src/github.com/openshift/origin/internal/controller/controllers/infraenv_controller.go:344" go-id=562 infra_env=myinfraenv infra_env_namespace=default request_id=9b15c534-b835-474d-9514-53faf2a5c6f5
`

https://github.com/openshift/assisted-service/blob/81a252cd6ee42175410e7da038a5ac4d237aa71a/internal/controller/controllers/infraenv_controller.go#L344


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Deploy the service skipper make deploy-test
2. Enable KubeApi - skipper make enable-kube-api-for-subsystem
3. Apply yamls on docs/crds - https://github.com/openshift/assisted-service/tree/master/docs/crds by the following order:
  - clusterDeployment.yaml
  - agentClusterInstall.yaml
  - pullsecret.yaml
  - clusterImageSet.yaml
  - infraEnv.yaml


Actual results:
Log message: 
"Image myinfraenv being prepared for cluster "

Expected results:
"Image myinfraenv being prepared for cluster <cluster_name>"

Additional info:

Comment 5 nshidlin 2021-07-05 11:54:56 UTC

Verified with: 2.3.0-DOWNSTREAM-2021-07-02-22-02-33

time="2021-07-05T11:52:35Z" level=info msg="Image sno-0 being prepared for cluster sno-0" func="github.com/openshift/assisted-service/internal/controller/controllers.(*InfraEnvReconciler).handleEnsureISOErrors" file="/remote-source/assisted-service/app/internal/controller/controllers/infraenv_controller.go:360" go-id=828 infra_env=sno-0 infra_env_namespace=sno-0 request_id=f98c5010-bb7e-421f-b4c0-8497153cc5e1

Comment 7 errata-xmlrpc 2021-07-27 23:12:22 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438