Bug 197013 (perl-RRD-Simple)
Summary: | Review Request: perl-RRD-Simple | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-06-28 14:31:56 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Chris Weyl
2006-06-28 01:46:53 UTC
Everything looks good with this tiny package; the only issue is that rpmlint doesn't like the license: W: perl-RRD-Simple invalid-license Apache Software License, Version 2.0 At this point we have no standard way to specify the version of a license, a deficiency which I hope to correct once the packaging committee gets going. What you have seems fine. BR: perl is redundant; perl is in the default buildroot. There's no need to pass %optflags for a noarch package. No blockers. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text included in package. * source files match upstream: 5a9a90877b4a99da15eac0eb52729773 RRD-Simple-1.39.tar.gz * latest version is being packaged. O BuildRequires are proper (BR: perl is redundant) * package builds in mock (development, x86_64). O rpmlint has only ignorable complaints. * final provides and requires are sane: perl(RRD::Simple) = 682 perl(RRD::Simple::_Colour) perl-RRD-Simple = 1.39-0.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Exporter) perl(File::Basename) perl(File::Spec) perl(RRDs) perl(strict) perl(vars) * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is present and all tests pass: All tests successful, 2 subtests skipped. Files=14, Tests=6440, 5 wallclock secs ( 4.69 cusr + 0.80 csys = 5.49 CPU) (skipped tests are not due to missing modules) * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED Thanks for the review! Built for FC-4, 5, and devel. |