Bug 1970437

Summary: [oVirt] Add guaranteed memory field to oVirt Machine Object
Product: OpenShift Container Platform Reporter: Evgeny Slutsky <eslutsky>
Component: Cloud ComputeAssignee: Evgeny Slutsky <eslutsky>
Cloud Compute sub component: oVirt Provider QA Contact: Guy <gafik>
Status: CLOSED ERRATA Docs Contact:
Severity: medium    
Priority: high CC: gzaidman, jpasztor, mburman, mimccune, pelauter
Version: 4.8   
Target Milestone: ---   
Target Release: 4.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1984481 (view as bug list) Environment:
Last Closed: 2021-10-18 17:33:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1942047    

Description Evgeny Slutsky 2021-06-10 13:29:18 UTC
Description of problem:

when creating nodes, openshift set the vm memory value according with the user input. However, using api/sdk, rhv/ovirt doesn't automatically set guarantee_memory based on the memory input but it gets a default value from the blanket template, which is 1Gb.

Testing steps:

# extract the machineset name
machineset=$(oc get machinesets -n openshift-machine-api -o template --template '{{range.items}}{{.metadata.name}}{{"\n"}}{{end}}')

# patch the machineset with guaranteed_memory_mb value
oc patch machineset $machineset --type='merge' --patch='{"spec": { "template": { "spec": { "providerSpec": { "value": { "guaranteed_memory_mb": "16000"}}}}}}' -n openshift-machine-api

# create new workers by scaling up the machineset
oc scale machineset $machineset --replicas=3 -n openshift-machine-api

#verify
- wait for the new workers to appear at the oVirt engine
- verify the new workers in oVirt engine have "Physical Memory Guaranteed" field set to new value (default is 1024MB)

Comment 1 Janos Bonic 2021-07-01 11:47:04 UTC
High/High seems a bit excessive. @pelauter can you please review this?

Comment 3 Guy 2021-08-17 11:28:14 UTC
verified in OpenShift cluster 4.9.0-0.nightly-2021-08-14-065522
and ovirt-engine ovirt-engine-4.4.8.2-0.11.el8ev.noarch

Comment 7 errata-xmlrpc 2021-10-18 17:33:33 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.9.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:3759