Bug 1970932

Summary: [RHEL9] integritysetup format failed and feedback Invalid argument
Product: Red Hat Enterprise Linux 9 Reporter: guazhang <guazhang>
Component: cryptsetupAssignee: Ondrej Kozina <okozina>
Status: CLOSED CURRENTRELEASE QA Contact: guazhang <guazhang>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 9.0CC: agk, jbrassow, okozina, prajnoha
Target Milestone: beta   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: cryptsetup-2.3.6-1.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-12-07 21:35:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description guazhang@redhat.com 2021-06-11 13:48:04 UTC
Description of problem:
cryptsetup regression hit the error, please have a look if hit a bug

Version-Release number of selected component (if applicable):
integritysetup-2.3.5-4.el9.x86_64

How reproducible:
100%

Steps to Reproduce:

1. integritysetup format --integrity-legacy-padding -q --integrity hmac-sha256  --sector-size 4096 --integrity-key-file key.img --integrity-key-size 4096  /dev/mapper/vg01-lv01 


Jun 11 15:23:15 storageqe-90 kernel: device-mapper: table: 253:2: integrity: Invalid number of feature args
Jun 11 15:23:15 storageqe-90 kernel: device-mapper: ioctl: error adding target to table
Jun 11 15:34:00 storageqe-90 kernel: device-mapper: table: 253:2: integrity: Invalid number of feature args
Jun 11 15:34:00 storageqe-90 kernel: device-mapper: ioctl: error adding target to table
Jun 11 15:42:08 storageqe-90 kernel: device-mapper: table: 253:2: integrity: Invalid number of feature args
Jun 11 15:42:08 storageqe-90 kernel: device-mapper: ioctl: error adding target to table
                                                                                         

Actual results:
run cmd failed 

Expected results:
run pass 

Additional info:

test pass with --integrity-key-size 32   

integritysetup format --integrity-legacy-padding -q --integrity hmac-sha256  --sector-size 4096 --integrity-key-file key.img --integrity-key-size 32  /dev/mapper/vg01-lv01

Comment 1 Ondrej Kozina 2021-06-15 08:46:58 UTC
There was a bug in dm integrity table line processing in integritysetup. It was fixed in upstream 2.3.6 release. See: https://mirrors.edge.kernel.org/pub/linux/utils/cryptsetup/v2.3/v2.3.6-ReleaseNotes

Comment 5 guazhang@redhat.com 2021-06-17 06:54:28 UTC
test passed with the fixed package cryptsetup-2.3.6-1.el9

integritysetup format --integrity-legacy-padding -q --integrity hmac-sha256  --sector-size 4096 --integrity-key-file key.img --integrity-key-size 4096  /dev/mapper/vg01-lv01