Bug 1971840
| Summary: | Please replace genisoimage with xorriso | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 9 | Reporter: | Jiri Kucera <jkucera> |
| Component: | edk2 | Assignee: | Laszlo Ersek <lersek> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Xueqiang Wei <xuwei> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 9.0 | CC: | apevec, bdobreli, berrange, coli, jinzhao, juzhang, kkiwi, kraxel, lersek, mrezanin, pbonzini, philmd, smooney, virt-maint |
| Target Milestone: | beta | Keywords: | RFE, Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | edk2-20210527gite1999b264f1f-2.el9 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-12-07 21:50:14 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1938254 | ||
| Bug Blocks: | 2002949 | ||
|
Description
Jiri Kucera
2021-06-14 20:16:15 UTC
Laszlo, this sounds important (and urgent, since it's RHEL9 compose-related?). Should this be assigned to you? Let me know otherwise. -Klaus Hi Klaus, it's best to update the RHEL9 spec file after the RHEL-9 rebase of edk2 (= rebuild of RHEL-8.5 SRPM). Thanks Laszlo (In reply to Jiri Kucera from comment #0) > cdrkit is going to be removed from RHEL 9 since it is not actively developed > for a long time. xorriso from libisoburn is genisoimage's alternative. > > Fedora PR: https://src.fedoraproject.org/rpms/edk2 > - genisoimage -input-charset ASCII -J -rational-rock \ > - -efi-boot "${vfat##*/}" -no-emul-boot -o "$iso" -- "$vfat" > + mkisofs -input-charset ASCII -J -rational-rock \ > + -e "${vfat##*/}" -no-emul-boot -o "$iso" "$vfat" I prefer using verbose option names (command lines in general) in spec files, so in RHEL9 we should replace "-efi-boot" with "--efi-boot", not "-e". Furthermore, removing the "--" option/operand delimiter seems unwarranted, we should keep it in RHEL9, even if only for readability's sake. Thanks. Bug 1938254 is now in MODIFIED state, so work can commence on this downstream-only update. (In reply to Laszlo Ersek from comment #3) > (In reply to Jiri Kucera from comment #0) > > cdrkit is going to be removed from RHEL 9 since it is not actively developed > > for a long time. xorriso from libisoburn is genisoimage's alternative. > > > > Fedora PR: https://src.fedoraproject.org/rpms/edk2 > > > - genisoimage -input-charset ASCII -J -rational-rock \ > > - -efi-boot "${vfat##*/}" -no-emul-boot -o "$iso" -- "$vfat" > > + mkisofs -input-charset ASCII -J -rational-rock \ > > + -e "${vfat##*/}" -no-emul-boot -o "$iso" "$vfat" > > I prefer using verbose option names (command lines in general) in spec > files, so in RHEL9 we should replace "-efi-boot" with "--efi-boot", not > "-e". Furthermore, removing the "--" option/operand delimiter seems > unwarranted, we should keep it in RHEL9, even if only for readability's sake. My preferences do not work, unfortunately, due to various bugs in the "mkisofs" wrapper of "xorriso". It's not a drop-in replacement. The Fedora changes are justified, but they were not explained. Regression testing (with any UefiShell.iso-related tasks from the test plan) should suffice here -- in fact the package build process itself only completes if UefiShell.iso is built correctly and behaves correctly. QE bot(pre verify): Set 'Verified:Tested,SanityOnly' as gating/tier1 test pass. Tested edk2 test loop(secure boot, uefi shell commands, https installation, pxe installation and so on), no new bug found. So set status to VERIFIED. Versions: kernel-5.13.0-0.rc7.51.el9.x86_64 qemu-kvm-6.0.0-7.el9 edk2-20210527gite1999b264f1f-2.el9 |