Bug 1972532

Summary:	[4.8.0] Misleading error when ClusterImageSet specifies OpenShift version lower than 4.8
Product:	Red Hat Advanced Cluster Management for Kubernetes	Reporter:	Michael Filanov <mfilanov>
Component:	unspecified	Assignee:	Rom Freiman <rfreiman>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bjacot
Severity:	low	Docs Contact:
Priority:	low
Version:	rhacm-2.3	CC:	aos-bugs, bjacot, juhsu, mhrivnak, mko, yfirst
Target Milestone:	---	Keywords:	Triaged
Target Release:	rhacm-2.3.1	Flags:	ming: rhacm-2.3.z+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	KNI-EDGE-JUKE-4.8 AI-Team-Hive
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1968570	Environment:
Last Closed:	2021-09-20 21:15:36 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1968570
Bug Blocks:

Description Michael Filanov 2021-06-16 06:56:54 UTC

+++ This bug was initially created as a clone of Bug #1968570 +++

+++ Description of problem:

The error message returned to the operator when trying to create installation with OpenShift version lower than 4.8 is slightly misleading

+++ Steps to Reproduce:

1. Create ClusterImageSet "openshift-v4.7.14" pointing to "quay.io/openshift-release-dev/ocp-release:4.7.14-x86_64"
2. Create AgentClusterInstall with imageSetRef "openshift-v4.7.14"
3. Create ClusterDeployment
4. Create InfraEnv

+++ Actual results:

ACI shows error "BackendError" with reason "The Spec could not be synced due to backend error: OCP version is not specified in OPENSHIFT_VERSIONS: 4.7"

IE shows error "ImageCreationError" with reason "Failed to create image: record not found"

+++ Expected results:

As an operator it's not completely clear to me that "OCP version is not specified [...]" is equivalent to the check being performed here (i.e. whether it's at least version 4.8

--- Additional comment from mhrivnak on 20210607T15:17:32

A k8s API message should not mention specific environment variables. Here, a more clear message would be something like "RHCOS image is not configured for version 4.7". A hint about where to go to configure it would be a bonus.

Comment 1 Raz Regev 2021-06-29 12:37:50 UTC

merged to ocm-2.3
14f492489e48145db63c11e68db621ec9e11950a

Comment 12 ximhan 2021-08-20 07:26:57 UTC

OpenShift engineering has decided to NOT ship 4.8.6 on 8/23 due to the following issue.
https://bugzilla.redhat.com/show_bug.cgi?id=1995785
All the fixes part will be now included in 4.8.7 on 8/30.

Comment 16 Mike Ng 2021-09-03 14:02:53 UTC

G2Bsync 912086419 comment 
 CrystalChun Thu, 02 Sep 2021 21:56:09 UTC 
 G2Bsync Fix was merged as part of ACM 2.3 GA
Picked up in https://github.com/open-cluster-management/backlog/issues/13873