Bug 1973318

Summary: Image pruner does not use custom tolerations
Product: OpenShift Container Platform Reporter: Oleg Bulatov <obulatov>
Component: Image RegistryAssignee: Oleg Bulatov <obulatov>
Status: CLOSED ERRATA QA Contact: Wenjing Zheng <wzheng>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.6CC: aos-bugs, wewang, ychoukse
Target Milestone: ---   
Target Release: 4.9.0   
Hardware: Unspecified   
OS: Unspecified   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: The operator to check if the registry should use custom tolerations was checking spec.nodeSelector instead of spec.tolerations. Consequence: The custom tolerations from spec.tolerations are applied only when spec.nodeSelector is set. Fix: Use the field spec.tolerations to check presence of custom tolerations. Result: The operator uses custom tolerations if spec.tolerations are set.
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-10-18 17:35:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1973662    

Description Oleg Bulatov 2021-06-17 15:48:50 UTC
Description of problem:

When custom tolerations are set via the imagepruner resource, the operator doesn't propagete them into the cronjob.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. set spec.tolerations on imagepruner

Actual results:

The image pruner cron job uses these tolerations.

Expected results:

Default tolerations are always used.

Additional info:

Comment 2 Wenjing Zheng 2021-06-25 06:35:50 UTC
Verified on 4.9.0-0.nightly-2021-06-24-123715:
    failedJobsHistoryLimit: 3
    ignoreInvalidImageReferences: true
    keepTagRevisions: 3
    logLevel: Normal
    schedule: '* * * * *'
    successfulJobsHistoryLimit: 3
    suspend: false
    - effect: NoSchedule
      key: key
      operator: Equal
      value: value

Comment 7 errata-xmlrpc 2021-10-18 17:35:03 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.9.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.