Bug 1974077

Summary:	[Assisted-4.8] [Staging][Network Latency] Improve validation message: host with IP not found in inventory
Product:	OpenShift Container Platform	Reporter:	Lital Alon <lalon>
Component:	assisted-installer	Assignee:	Jordi Gil <jgil>
assisted-installer sub component:	assisted-service	QA Contact:	Yuri Obshansky <yobshans>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	high
Priority:	unspecified	CC:	aos-bugs, gharden, jgil
Version:	4.8	Keywords:	Triaged
Target Milestone:	---	Flags:	lalon: needinfo- lalon: needinfo- lalon: needinfo-
Target Release:	4.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	AI-Team-Projects
Fixed In Version:	OCP-Metal-v1.0.25.1	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-10-18 17:35:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lital Alon 2021-06-20 12:22:21 UTC

Description of problem:
when simulating a packet loss, the following validation message appear:

"Error while attempting to validate packet loss validation: host with IP 192.168.127.11 not found in inventory."

"Not found in inventory" is not a clear message for the end user. 
relevant for both:
sufficient-network-latency-requirement-for-role
sufficient-packet-loss-requirement-for-role

Version-Release number of selected component (if applicable):
Staging, v1.0.22.1

Steps to Reproduce:
1. boot 3 master nodes, and simulate packet loss \ network latency > 100ms on one node i.e 
'sudo tc qdisc add dev ens3 root netem loss 10%'


Actual results:
Host is Insufficient with: "Error while attempting to validate packet loss validation: host with IP 192.168.127.13 not found in inventory."

Expected results:
A suggestion: "Error while attempting to validate packet loss validation: host with IP 192.168.127.13 failed validation."

Comment 1 Lital Alon 2021-07-18 11:09:59 UTC

@jgil Please add fix PR.

Tested over Integration, it appears that New message missing or has empty %s after 'between':
"Network latency requirements of less or equals than 100.000 ms not met for connectivity between and test-infra-cluster-gfdhfg-master-0"
See attached example

Comment 4 Lital Alon 2021-08-02 15:13:52 UTC

Any particular reason for having host id instead of host name? i.e

Packet loss: Packet loss percentage requirement of less or equals than 0.00% not met for connectivity between 5c2353d2-7335-486a-b5ee-d0312d3ba04f and test-infra-cluster-e7a708bb-master-0,test-infra-cluster-e7a708bb-master-1.

Comment 5 Lital Alon 2021-08-04 16:08:24 UTC

@gharden suggested to replace wording "less or equals than":
"Packet loss percentage requirement of less or equals than 0.00% not met.."

with:
"Packet loss percentage requirement of less than or equals 0.00% not met"

or we can use <=

Comment 6 gharden 2021-08-04 17:54:57 UTC

"Packet loss percentage requirement of less than or equal to 0.00% not met for connectivity between..."
"Packet loss percentage requirement <= 0.00% not met for connectivity between..."

Either on of these would fine

Comment 7 gharden 2021-08-04 17:56:30 UTC

Correction:

"Packet loss percentage requirement less than or equal to 0.00% not met for connectivity between..."
"Packet loss percentage requirement <= 0.00% not met for connectivity between..."

Either on of these would fine

Comment 8 Jordi Gil 2021-08-12 18:35:34 UTC

Message proposed to be changed as follows:
* If threshold is = 0, the comparison drops "less than": "Packet loss percentage requirement of equals 0% ..."
* If threshold is >0, the message is "Packet loss percentage requirement of less than or equals 10%"

Example:

"Packet loss percentage requirement of equals 0.00% not met for connectivity between 2dbe6092-2bdf-432b-ace9-7b0cd0013499 and master-1 (1.00%), master-2 (1.00%)."

Comment 10 Lital Alon 2021-08-31 13:21:51 UTC

Verified on Staging, v1.0.25.2

Comment 13 errata-xmlrpc 2021-10-18 17:35:50 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.9.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:3759