Bug 1974149

Created attachment 1792568 [details]
Consider background-color, background-size and background-position

The artwork itself looks too small when the installer runs in a resolutions higher than 1024x768 pixels. By considering also the background-size and background-position it should be possible to expand the artwork and cover the visible area in a more more compelling way.

possible target for the CentOS Stream Feature Request SIG ?

Ideally this should be done in a way that works for both RHEL and CentOS.  I'm almost done getting all the CentOS modifications into upstream anaconda, I'm not interested in adding more CentOS-only stuff.  I'll defer to the anaconda devs on the best way to approach this.

Hi, the centos-logos package should provide a custom stylesheet with overrides for CentOS. Then Anaconda can set the custom_stylesheet option of the CentOS configuration file to this new stylesheet. This solution can be applied to RHEL 8, RHEL 9 and upstream. We have recently done that for RHEL (see the bug 1928711).

Alain, it sounds like what we need is a custom stylesheet in https://github.com/CentOS/centos-logos/tree/c8/anaconda, then we can put it into the next build of centos-logos.

Yes. I just saw we are already using that model for CS9 (centos-logos:/anaconda/theme/readhat.css). So, let's try it for CS8 as well.

In CS8's case: once we put the css file under centos-logos:/anaconda/theme/, what would happen with the anaconda-gtk.css file in anaconda package? Do we need to touch anaconda and centos-logos spec files, so they don't try to copy the same file?

I've validated the usage of `background-size` and `background-position` to scale the image on different resolutions. They work the way expected. I did the test rebuilding the iso with the changes inside, then run  virtual machine passing the `vga=ask` parameter in anaconda boot screen an selecting different resolutions available there. Reference used https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html-single/customizing_anaconda/index#customizing-graphical-elements_branding-and-chroming-the-graphical-user-interface

By using `background-size: contain;` the results obtained were better than using `background-size: cover;`. The artwork scales proportionally on different resolutions covering the entire area. The sidebar-bg.png expands horizontally while topbar-bg.png expands vertically. The relation between the background-image and the background-color is still very important to achieve a nice fading effect. Here I attach some screenshots of the tests.

Created attachment 1794204 [details]
anaconda-800x600-sidebar-bg.png

Created attachment 1794205 [details]
anaconda-800x600-topbar-bg.png

Created attachment 1794207 [details]
anaconda-1024x768-sidebar-bg.png

Created attachment 1794208 [details]
anaconda-1024x768-topbar-bg.png

Created attachment 1794209 [details]
anaconda-1280x1024-sidebar-bg.png

Created attachment 1794210 [details]
anaconda-1280x1024-topbar-bg.png

Created attachment 1794211 [details]
anaconda-1600x1200-sidebar-bg.png

Created attachment 1794212 [details]
anaconda-1600x1200-topbar-bg.png

Created attachment 1794213 [details]
anaconda-centos-background-color-size-position.patch

Created attachment 1794250 [details]
anaconda-1600x1200-sidebar-bg-auto.png

This image illustrates the issue. Note the empty space on the right side of the background image. The fading effect was removed from the background image to make the space wasted more visible. This empty space is even wider on larger screen resolutions when image is not scaled.

Created attachment 1794252 [details]
anaconda-1600x1200-topbar-bg-auto.png

The image doesn't scale to the container height, so part of the image is lost. Compare with previous screenshots.

These changes are available upstream in version 85.6 [0], which has been built as centos-logos-85.6-1.el8 [1].  I'll run a compose for this next week sometime.

[0] https://github.com/CentOS/centos-logos/releases/tag/85.6
[1] https://koji.mbox.centos.org/koji/buildinfo?buildID=18218

We discovered that this custom stylesheet will also need a small patch for anaconda.  I've submitted that to the upstream rhel-8 branch [0], referencing this bug.  I've already applied it as a "debranding" modification to the CentOS anaconda-33.16.5.2-1.el8 build [1].  A test compose confirmed this works now, so I'll push those builds out soon.


[0] https://github.com/rhinstaller/anaconda/pull/3477
[1] https://koji.mbox.centos.org/koji/buildinfo?buildID=18333

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (anaconda bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4254