Bug 197484
Summary: | Review Request: perl-Class-MakeMethods | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
Component: | Package Review | Assignee: | Jochen Schmitt <jochen> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | iarnell, imlinux |
Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-07-05 15:47:06 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Chris Weyl
2006-07-02 21:11:46 UTC
Good: + tarballs in SRPM match upstream version. + rpmlint doensn't complaints source rpm. + Local Build works fine. + Mock build works fine. + rpmlint doesn't complaints binary rpm. + License is the same as perl. Bad: - perl should not be included - Package doesn't contain verbatin license text. Jochen, are you reviewing this? You should block FE-REVIEW instead of FE-NEW is you are. Note that BR: perl is in the optional list; generally we don't see it as a blocker. I can't tell if you're inticating that it's a blocker or not. Also note that it is quite rare for a Perl module to include the verbatim license text, and it not a blocker to fail to include the license text in the package when the upstream tarball does not include it. Just some friendly comments. Thanks for helping out with the reviews. @Jason, Thank you for your clarification. @Christ, After the clarification from Jason, I will be able to APPROVE you package. Imported and built for devel; will build for FC-[45] after branching. Thanks for the review! Is this actually Approved or still waiting for approval? Given the blocker bug was switched from FE-REVIEW to FE-ACCEPT, I understood comment #3 to be an approval. Package Change Request ====================== Package Name: perl-Class-MakeMethods New Branches: el6 Owners: iarnell tremble Git done (by process-git-requests). |