Bug 1975157

Summary:	(release-4.9) records data size is incorrectly growing when obfuscation is enabled or when there are duplicated records
Product:	OpenShift Container Platform	Reporter:	Tomas Remes <tremes>
Component:	Insights Operator	Assignee:	Tomas Remes <tremes>
Status:	CLOSED ERRATA	QA Contact:	Dmitry Misharov <dmisharo>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.9	CC:	aos-bugs, inecas, mklika, psimovec, tremes
Target Milestone:	---	Keywords:	Reopened
Target Release:	4.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:	1967949	Environment:
Last Closed:	2021-10-18 17:36:21 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1967949

Description Tomas Remes 2021-06-23 08:16:19 UTC

+++ This bug was initially created as a clone of Bug #1967949 +++

Description of problem:
Records data size (in recorder.go) is incorrectly growing when obfuscation is enabled (because we don't use the obfuscated record name to store the corresponding record) or when there are duplicated records (duplicated record is not correctly checked which leads to overwriting and increasing the size)

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Tomas Remes 2021-06-23 08:19:19 UTC

Already fixed with https://github.com/openshift/insights-operator/pull/444

Comment 2 Dmitry Misharov 2021-07-07 13:12:15 UTC

Verified on OCP 4.9.0-0.nightly-2021-07-07-021823.

Verification steps:

1. Download an insights-operator archive
2. Check files in /config/machineconfigs/
3. You should have something similar:

/config/machineconfigs/00-master.json
/config/machineconfigs/00-worker.json
/config/machineconfigs/01-master-container-runtime.json
/config/machineconfigs/01-master-kubelet.json
/config/machineconfigs/01-worker-container-runtime.json
/config/machineconfigs/01-worker-kubelet.json
/config/machineconfigs/99-master-generated-registries.json
/config/machineconfigs/99-master-ssh.json
/config/machineconfigs/99-worker-generated-registries.json
/config/machineconfigs/99-worker-ssh.json
/config/machineconfigs/rendered-master-5741db177786fe8c767d6d9dba32a3fc.json
/config/machineconfigs/rendered-worker-44f533a629ec81654c116f454e864ed7.json

Comment 3 Dmitry Misharov 2021-07-07 13:13:45 UTC

Discarding comment #2. Wrong BZ.

Comment 4 Dmitry Misharov 2021-07-20 08:58:42 UTC

Verified on 4.9.0-0.nightly-2021-07-19-224913.

Verification steps:

1. Enable obfuscation
2. Check the archive content and size

Comment 7 errata-xmlrpc 2021-10-18 17:36:21 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.9.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:3759