Bug 1975340
| Summary: | netdata update overwrites configuration | ||
|---|---|---|---|
| Product: | [Fedora] Fedora EPEL | Reporter: | Filippo Carletti <filippo.carletti> |
| Component: | netdata | Assignee: | Didier Fabert (tartare) <didier.fabert> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | epel7 | CC: | didier.fabert, fedora |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | netdata-1.39.1-1.fc37 netdata-1.39.1-1.el9 netdata-1.39.1-1.el8 netdata-1.39.1-1.el7 netdata-1.39.1-1.fc38 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-05-30 01:07:47 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Filippo Carletti
2021-06-23 13:02:43 UTC
Hi Filippo, noreplace has been removed for good reason but not documented (my bad due to not enough time) For netdata, conf.d is not a directory with secondary/partial conf files but just a stock of configuration. And yes the name is not appropriate (template will be a better name). Each config file in /etc/netdata/conf.d must be edited with /usr/libexec/netdata/edit-config In your case (whatever your current path), you must override the file by typing sudo /usr/libexec/netdata/edit-config python.d.conf The modified file will be saved as /etc/netdata/python.d.conf and because this file is not included in rpm package, it will never be replaced. I apologize for the matter, I promise to found time to write doc asap. Oops, I should have known how to configure netdata, but I obviously forgot the details when I modified python.d.conf. Noticing the removal of noreplace took me to the wrong path. To be fair, /etc/netdata/conf.d is a pretty surprising location for a stock configuration directory, where files shouldn't be modified and don't survive a package update. Also, netdata has moved on and switched the default to /usr/lib/netdata/conf.d, which arguably is a much saner choice, and follows a common pattern used by other well known software. Thus, when looking at the netdata online documentation one has to dig quite a bit to get what /etc/netdata/conf.d actually is about. Hence, I suggest to switch the fedora package to the upstream default, i.e. also just install the stock configuration files under /usr/lib/netdata/conf.d! As a positive side effect, this would eliminate the need to 'spam' the environment with a bunch of Netdata specific variables (because all defaults work). I mean currently, my environment reads: # cat /etc/fedora-release Fedora release 35 (Thirty Five) # rpm -q netdata netdata-1.33.1-2.fc35.x86_64 # export | grep NETDATA NETDATA_CACHE_DIR=/var/cache/netdata NETDATA_STOCK_CONFIG_DIR=/etc/netdata/conf.d NETDATA_USER_CONFIG_DIR=/etc/netdata NETDATA_VARLIB_DIR=/var/lib/netdata IMO the location is not a surprising one because this is configuration files anyway and it's not surprising that conf files are located in /etc. But The dir name is surprising (name from upstream).
But I agree that is confusing and is not a good solution.
Without any change, conf.d will be located in %{_libdir}, which is /usr/lib for i386 but /usr/lib64 on x86_64 arch. This breaks packaging rules.
Currently I modify package to put stock configuration directory in /usr/lib/netdata/conf.d but a trigger must be set in case of update package.
This changes will be present in the next release (1.34.1)
FEDORA-2023-0b483891c6 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-0b483891c6 FEDORA-2023-88202e49cd has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-88202e49cd FEDORA-EPEL-2023-a0be4e1a3b has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-a0be4e1a3b FEDORA-EPEL-2023-d2552e4817 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-d2552e4817 FEDORA-EPEL-2023-df65ce1916 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-df65ce1916 FEDORA-EPEL-2023-df65ce1916 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-df65ce1916 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-0b483891c6 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-0b483891c6 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-0b483891c6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2023-a0be4e1a3b has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-a0be4e1a3b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2023-d2552e4817 has been pushed to the Fedora EPEL 7 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-d2552e4817 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-88202e49cd has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-88202e49cd \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-88202e49cd See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-0b483891c6 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2023-df65ce1916 has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2023-a0be4e1a3b has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2023-d2552e4817 has been pushed to the Fedora EPEL 7 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-88202e49cd has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. |