Bug 1975677

Summary: libiscsi is going to be removed from RHEL 9
Product: Red Hat Enterprise Linux 9 Reporter: Miroslav Rezanina <mrezanin>
Component: libvirtAssignee: Jiri Denemark <jdenemar>
Status: CLOSED CURRENTRELEASE QA Contact: Meina Li <meili>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 9.0CC: areis, chwen, coli, hhan, jdenemar, meili, pkrempa, smitterl, timao, virt-maint, xuzhang
Target Milestone: betaKeywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libvirt-7.5.0-1.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-12-07 21:57:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version: 7.5.0
Embargoed:

Description Miroslav Rezanina 2021-06-24 07:59:58 UTC
With BZ 1967133, qemu-kvm-block-iscsi package will be removed (as a first step to libiscsi removal). Libvirt has to be updated to handle this change.

Comment 1 Miroslav Rezanina 2021-06-24 08:07:06 UTC
I wrongly understand dependency chain. libvirt is using libiscsi directly without dependency on qemu-kvm. However, libiscsi itself will be removed and we need to get rid of all dependencies requiring this package so libvirt has to remove iscsi storage driver.

Comment 2 Jiri Denemark 2021-06-24 09:02:03 UTC
Patch sent upstream for review: https://listman.redhat.com/archives/libvir-list/2021-June/msg00721.html

BTW, iscsi storage driver access storage via block devices in /dev provided by
the iSCSI kernel driver. We need to disable iscsi-direct storage driver to
remove libiscsi dependency.

Comment 3 Jiri Denemark 2021-06-24 09:11:27 UTC
Pushed upstream as

commit b3bbe5d8f58ccb81ab40ad2b6c3df5d1c0b70139
Refs: v7.4.0-248-gb3bbe5d8f5
Author:     Jiri Denemark <jdenemar>
AuthorDate: Thu Jun 24 10:18:17 2021 +0200
Commit:     Jiri Denemark <jdenemar>
CommitDate: Thu Jun 24 11:08:54 2021 +0200

    spec: Drop libiscsi support in RHEL-9

    https://bugzilla.redhat.com/show_bug.cgi?id=1975677

    Signed-off-by: Jiri Denemark <jdenemar>
    Reviewed-by: Ján Tomko <jtomko>

Comment 5 Han Han 2021-06-25 08:57:02 UTC
Pre-verfiy it since libiscsi is disbaled in spec file.

Comment 6 Han Han 2021-06-28 07:17:32 UTC
Meili, this update will only disable iscsi-direct storage pools.
Assign it to you.

Comment 10 Meina Li 2021-07-21 03:54:45 UTC
Hi,Jiri :
Can we have a clearer error message like "not support iscsi-direct" when defining an iscsi-direct pool?
I think the current error message "internal error: missing backend for pool type 6 (iscsi-direct)" may confuse us sometimes. Thanks.

Test Version:
libvirt-7.5.0-1.el9.x86_64
qemu-kvm-6.0.0-9.el9.x86_64

Test Steps:
1. Check the current packages which are related with iscsi.
# rpm -qa | grep iscsi
libiscsi-1.19.0-4.el9.x86_64
iscsi-initiator-utils-iscsiuio-6.2.1.2-7.gita8fcb37.el9.x86_64
iscsi-initiator-utils-6.2.1.2-7.gita8fcb37.el9.x86_64
libvirt-daemon-driver-storage-iscsi-7.5.0-1.el9.x86_64
libvirt-daemon-driver-storage-iscsi-debuginfo-7.5.0-1.el9.x86_64
---Don't include qemu-kvm-block-iscsi and iscsi-direct related packages
2. Define an iscsi-direct pool
# virsh pool-define iscsi-direct.pool 
error: Failed to define pool from iscsi-direct.pool
error: internal error: missing backend for pool type 6 (iscsi-direct)

Comment 11 Peter Krempa 2021-07-21 06:59:10 UTC
(In reply to Meina Li from comment #10)
> Hi,Jiri :
> Can we have a clearer error message like "not support iscsi-direct" when
> defining an iscsi-direct pool?

No as this would require downstream only patches. From the upstream point of view ...

> I think the current error message "internal error: missing backend for pool
> type 6 (iscsi-direct)" may confuse us sometimes. Thanks.

... this error message is okay, since it indicates that the backend for 'iscsi-direct' is not compiled or installed and there's no upstream notion of iscsi-direct being "unsupported.

Comment 12 Jiri Denemark 2021-07-21 07:42:58 UTC
I don't think the message is confusing. It clearly says the support for
iscsi-direct is missing. It doesn't say why it is missing (not installed vs.
disabled during build), but that would mean changing the error message
depending on how various parts of libvirt are enabled or disabled in the spec
or even shipped in case some subpackage is only shipped with a specific
product.

Comment 13 Meina Li 2021-07-22 01:08:03 UTC
According to comment 10 and comment 12, move this bug to be verified.

Comment 14 Peter Krempa 2021-07-26 18:23:05 UTC
*** Bug 1986114 has been marked as a duplicate of this bug. ***