Bug 1976399

Summary:	During the upgrade from OpenShift 4.5 to OpenShift 4.6 the election timers for the OVN north and south databases did not change.
Product:	OpenShift Container Platform	Reporter:	Alvaro Soto <asoto>
Component:	Networking	Assignee:	Federico Paolinelli <fpaoline>
Networking sub component:	ovn-kubernetes	QA Contact:	Dan Brahaney <dbrahane>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	high
Priority:	high	CC:	anbhat, arajapa, astoycos, bbennett, bhershbe, dansmall, dcbw, dwilson, ealcaniz, eglottma, trozet, zzhao
Version:	4.6	Flags:	arajapa: needinfo-
Target Milestone:	---
Target Release:	4.10.0
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-03-10 16:04:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Alvaro Soto 2021-06-25 23:43:26 UTC

Description of problem:
During the upgrade from OpenShift 4.5 to OpenShift 4.6 the election timers for the OVN north and south databases did not change.

Version-Release number of selected component (if applicable):
4.6.17

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 7 Ben Bennett 2021-07-14 21:01:14 UTC

Will this affect any upgrade other than 4.5 -> 4.6?

Are there any other 4.5 clusters with a supported ovn-kube left to upgrade?

Will the affected customer take a fixed 4.6.z to upgrade to?

If no to all the above, let's close this.

Comment 8 Federico Paolinelli 2021-07-23 10:12:47 UTC

(In reply to Ben Bennett from comment #7)
> Will this affect any upgrade other than 4.5 -> 4.6?
> 
> Are there any other 4.5 clusters with a supported ovn-kube left to upgrade?
> 
> Will the affected customer take a fixed 4.6.z to upgrade to?
> 
> If no to all the above, let's close this.

Noticed this comment only now.
4.5 -> 4.6 is the only place where we jump from 
        - name: OVN_NB_RAFT_ELECTION_TIMER
          value: "5000"
        - name: OVN_SB_RAFT_ELECTION_TIMER
          value: "5000"

to 
        - name: OVN_NB_RAFT_ELECTION_TIMER
          value: "10000"
        - name: OVN_SB_RAFT_ELECTION_TIMER
          value: "16000"

(and those values are still the same as 4.9). Despite this, the bug is there and if for some reason we need to change the value, it won't work.
I have both patches ready, I think it won't hurt to fix this in 4.9

Comment 9 Tim Rozet 2021-08-24 19:43:31 UTC

I think there was a bug in the ovnkube-patch:
https://github.com/ovn-org/ovn-kubernetes/pull/2447

I think we should get this fix in, as we need a live way to ensure the election timer is correct across the cluster. Doing it in ovndbchecker gives us that path.

Comment 10 Tim Rozet 2021-08-24 19:45:22 UTC

*** Bug 1970077 has been marked as a duplicate of this bug. ***

Comment 18 Dan Brahaney 2021-12-09 17:07:25 UTC

Verified on 4.10.0-0.nightly-2021-12-06-201335

Comment 21 errata-xmlrpc 2022-03-10 16:04:21 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056