Bug 197694

Summary: pykickstart should use defined constants for networking attributes ("dhcp", "static", "bootp")
Product: [Fedora] Fedora Reporter: James Laska <jlaska>
Component: pykickstartAssignee: Chris Lumens <clumens>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jturner
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-02-06 20:48:41 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
network_constants.patch none

Description James Laska 2006-07-05 15:52:26 UTC 
Follow on to IRC discussion.  

[Jul 05 11:45:39] <      jlaska> | ... should things like "dhcp" and "bootp" be
constants defined in constants.py
[Jul 05 11:45:44] <      jlaska> | or is that just me being anal?
[Jul 05 11:45:56] <     clumens> | hmmm
[Jul 05 11:46:11] <     clumens> | they probably should.
[Jul 05 11:46:42] <      jlaska> | I mean, it's not likely the string values
will change ... but ... well, your call
[Jul 05 11:47:45] <     clumens> | but at the same time, using strings for
constants like that is lame.
[Jul 05 11:51:21] <      jlaska> | want a bug for tracking?
[Jul 05 11:51:30] <     clumens> | sure

Suggested patch (UNTESTED) attached...
Comment 1 James Laska 2006-07-05 15:52:27 UTC 
Created attachment 131938 [details]
network_constants.patch