Bug 1977622

Summary: python-libpysal fails to build with Sphinx 4.0.2
Product: [Fedora] Fedora Reporter: Karolina Surma <ksurma>
Component: python-libpysalAssignee: Elliott Sales de Andrade <quantum.analyst>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 35CC: python-sig, quantum.analyst, thrnciar, zbyszek
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-09-02 09:48:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1976638    
Bug Blocks: 1890881, 1927309, 1973718, 1992484    

Description Karolina Surma 2021-06-30 08:04:34 UTC
python-libpysal fails to build with Sphinx 4.0.2 in Fedora 35 (currently Rawhide).

+ sphinx-build-3 docsrc html
Running Sphinx v4.0.2
making output directory... done
Exception occurred:
  File "/builddir/build/BUILD/libpysal-4.4.0/docsrc/conf.py", line 275, in setup
    app.add_stylesheet("pysal-styles.css")
AttributeError: 'Sphinx' object has no attribute 'add_stylesheet'

For the logs from testing build attempts, see:
https://copr.fedorainfracloud.org/coprs/ksurma/pygments-2.9.0/package/python-libpysal/


Possible solution for this issue:
In some cases it may be enough to replace the call to 'add_stylesheet' with 'add_css_file' instead.

You can test you package using Koji scratch build
koji build --scratch <srpm>

For details regarding the Sphinx change, see https://fedoraproject.org/wiki/Changes/Sphinx4
Let us know here if you have any questions. Thank you!

Comment 1 Ben Cotton 2021-08-10 13:10:15 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 35 development cycle.
Changing version to 35.

Comment 2 Zbigniew Jędrzejewski-Szmek 2021-09-02 09:48:34 UTC
I'll close this. In https://koji.fedoraproject.org/koji/taskinfo?taskID=74912614 the build
fails in tests:
+ /usr/bin/pytest
============================= test session starts ==============================
platform linux -- Python 3.10.0rc1, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
rootdir: /builddir/build/BUILD/libpysal-4.5.1.post2
collected 502 items
libpysal/test_NameSpace.py s                                             [  0%]
libpysal/cg/ops/tests/test_accessors.py ..........                       [  2%]
libpysal/cg/ops/tests/test_shapely.py ssssssssssssssssssssssssssssssssss [  8%]
s                                                                        [  9%]
libpysal/cg/ops/tests/test_tabular.py ..........                         [ 11%]
libpysal/cg/tests/test_ashapes.py ....                                   [ 11%]
libpysal/cg/tests/test_geoJSON.py ..                                     [ 12%]
libpysal/cg/tests/test_locators.py ......                                [ 13%]
libpysal/cg/tests/test_polygonQuadTreeStructure.py .                     [ 13%]
libpysal/cg/tests/test_rtree.py ..                                       [ 14%]
libpysal/cg/tests/test_segmentLocator.py ....                            [ 14%]
libpysal/cg/tests/test_shapes.py ....................................... [ 22%]
....                                                                     [ 23%]
libpysal/cg/tests/test_sphere.py ........                                [ 25%]
libpysal/cg/tests/test_standalone.py ................................... [ 32%]
...............................................                          [ 41%]
libpysal/cg/tests/test_voronoi.py F.                                     [ 41%]
libpysal/examples/tests/test_available.py .                              [ 42%]
libpysal/io/geotable/tests/test_utils.py ss                              [ 42%]
libpysal/io/iohandlers/tests/test_arcgis_dbf.py ....                     [ 43%]
libpysal/io/iohandlers/tests/test_arcgis_swm.py ....                     [ 44%]
libpysal/io/iohandlers/tests/test_arcgis_txt.py ....                     [ 44%]
libpysal/io/iohandlers/tests/test_csvWrapper.py .......                  [ 46%]
libpysal/io/iohandlers/tests/test_dat.py ....                            [ 47%]
libpysal/io/iohandlers/tests/test_db.py .                                [ 47%]
libpysal/io/iohandlers/tests/test_gal.py .....                           [ 48%]
libpysal/io/iohandlers/tests/test_geobugs_txt.py ....                    [ 49%]
libpysal/io/iohandlers/tests/test_geoda_txt.py ...                       [ 49%]
libpysal/io/iohandlers/tests/test_gwt.py ....                            [ 50%]
libpysal/io/iohandlers/tests/test_mat.py ....                            [ 51%]
libpysal/io/iohandlers/tests/test_mtx.py ....                            [ 51%]
libpysal/io/iohandlers/tests/test_pyDbfIO.py ........                    [ 53%]
libpysal/io/iohandlers/tests/test_pyShpIO.py ......                      [ 54%]
libpysal/io/iohandlers/tests/test_stata_txt.py ....                      [ 55%]
libpysal/io/iohandlers/tests/test_wk1.py ....                            [ 56%]
libpysal/io/iohandlers/tests/test_wkt.py ...                             [ 56%]
libpysal/io/tests/test_FileIO.py .                                       [ 57%]
libpysal/io/tests/test_Tables.py .                                       [ 57%]
libpysal/io/util/tests/test_shapefile.py ............................... [ 63%]
...                                                                      [ 64%]
libpysal/io/util/tests/test_weight_converter.py sss                      [ 64%]
libpysal/io/util/tests/test_wkt.py ....                                  [ 65%]
libpysal/weights/tests/test_Wsets.py ......                              [ 66%]
libpysal/weights/tests/test__contW_lists.py .........                    [ 68%]
libpysal/weights/tests/test_adjlist.py .....                             [ 69%]
libpysal/weights/tests/test_contiguity.py ..............                 [ 72%]
libpysal/weights/tests/test_distance.py .....................            [ 76%]
libpysal/weights/tests/test_nx.py .                                      [ 76%]
libpysal/weights/tests/test_raster.py .....                              [ 77%]
libpysal/weights/tests/test_spatial_lag.py ..                            [ 78%]
libpysal/weights/tests/test_spintW.py ........                           [ 79%]
libpysal/weights/tests/test_user.py ..                                   [ 80%]
libpysal/weights/tests/test_util.py ..............s......                [ 84%]
libpysal/weights/tests/test_weights.py ................................. [ 90%]
.............................................                            [ 99%]
libpysal/weights/tests/test_weights_IO.py .                              [100%]
=================================== FAILURES ===================================
_____________________________ Voronoi.test_voronoi _____________________________
self = <libpysal.cg.tests.test_voronoi.Voronoi testMethod=test_voronoi>
    def test_voronoi(self):
        regions, vertices = voronoi(self.points)
        self.assertEqual(regions, [[1, 3, 2], [4, 5, 1, 0], [0, 1, 7, 6], [9, 0, 8]])
    
>       self.assertTrue(vertices.tolist() == self.vertices)
E       AssertionError: False is not true
libpysal/cg/tests/test_voronoi.py:27: AssertionError

… but the sphinx phases passes fine.