Bug 1978342

Summary: git-cinnabar: ImportError: cannot import name 'Iterable' from 'collections' (/usr/lib64/python3.10/collections/__init__.py)
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: git-cinnabarAssignee: Elliott Sales de Andrade <quantum.analyst>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: quantum.analyst, thrnciar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: git-cinnabar-0.5.7-5.fc35 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-08-03 08:10:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1890881, 1927309    

Description Miro Hrončok 2021-07-01 15:34:50 UTC
Description of problem:
git-cinnabar fails to build in Rawhide with Python 3.10:

======================================================================
ERROR: dag (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: dag
Traceback (most recent call last):
  File "/usr/lib64/python3.10/unittest/loader.py", line 436, in _find_test_path
    module = self._get_module_from_name(name)
  File "/usr/lib64/python3.10/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/builddir/build/BUILD/git-cinnabar-0.5.7/tests/dag.py", line 3, in <module>
    from cinnabar.dag import gitdag
  File "/builddir/build/BUILD/git-cinnabar-0.5.7/cinnabar/dag.py", line 6, in <module>
    from .util import (
  File "/builddir/build/BUILD/git-cinnabar-0.5.7/cinnabar/util.py", line 19, in <module>
    from collections import (
ImportError: cannot import name 'Iterable' from 'collections' (/usr/lib64/python3.10/collections/__init__.py)


Version-Release number of selected component:
git-cinnabar-0.5.7-1.fc35

git-cinnabar was not included in the Python 3.10 mass rebuild as it does not require a specific Python version on runtime.

However, this error seems like something that can happen on runtime as well.



See https://docs.python.org/3.10/whatsnew/3.10.html#removed

"Remove deprecated aliases to Collections Abstract Base Classes from the collections module."

E.g. instead of collections.Iterable, use collections.abc.Iterable

Comment 1 Fedora Release Engineering 2021-07-11 04:23:15 UTC
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 35.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2021-08-26).

A week before the mass branching of Fedora 36 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 34 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-36/f-36-key-tasks.html

Comment 2 Fedora Release Engineering 2021-08-01 04:23:13 UTC
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 35.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2021-08-26).

A week before the mass branching of Fedora 36 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 34 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-36/f-36-key-tasks.html

Comment 3 Elliott Sales de Andrade 2021-08-02 02:45:31 UTC
This is fixed, but there are still test failures preventing the build.