Bug 197847

Summary:	Review Request: pymsnt - MSN Transport for Jabber Servers
Product:	[Fedora] Fedora	Reporter:	Jeffrey C. Ollie <jeff>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	j, pwb
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-10-28 17:55:02 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	201449

Description Jeffrey C. Ollie 2006-07-06 18:56:51 UTC

Spec URL: http://repo.ocjtech.us/misc/fedora/5/SRPMS/pymsnt-0.11-1.fc5.spec
SRPM URL: http://repo.ocjtech.us/misc/fedora/5/SRPMS/pymsnt-0.11-1.fc5.src.rpm
Description: 
The MSN Transport provides a gateway which allows Jabber users to
communicate with their contacts on the MSN Messenger network.

The transport must be installed on the Jabber server, and it's
operation is nearly transparent to the user. They can interact with
their MSN contacts in the same way as they do with their Jabber
contacts.

Comment 1 Jason Tibbitts 2006-07-12 00:16:35 UTC

Looks like you just beat 0.11.1 ouut.

Some rpmlint issues:
  E: pymsnt no-status-entry /etc/rc.d/init.d/pymsnt
  W: pymsnt mixed-use-of-spaces-and-tabs

Indeed, the init script doesn't accept status, and some lines in the spec are
indented with tabs while others use spaces.  (I.e. spaces for Source0 and tabs
for Source1.)

You don't seem to include the spool directory in the package.

In case you find making the %files list tedious, you might consider using the
stuff at the end of http://fedoraproject.org/wiki/Packaging/Python, which gets
it down to three find statements and a few calls to sed.

You don't seem to include the spool directory in the package.

Comment 2 Jeffrey C. Ollie 2006-07-26 13:39:45 UTC

Updated Spec/SRPM:

Spec URL: http://repo.ocjtech.us/misc/fedora/5/SRPMS/pymsnt-0.11.1-1.fc5.spec
SRPM URL: http://repo.ocjtech.us/misc/fedora/5/SRPMS/pymsnt-0.11.1-1.fc5.src.rpm

* Wed Jul 12 2006 Jeffrey C. Ollie <jeff> - 0.11.1-1
- Add (non-working) status option to init file.
- Update to 0.11.1
- Own /var/spool/pymsnt

I've added a status option to the init file, but it doesn't work...  I'm not
familiar enough with the init scripts to determine why it doesn't work, can
anyone out there give me a clue?

Comment 3 Peter Berry 2006-07-27 15:23:18 UTC

The group should be Applications/Communications.

The status option doesn't work because start() does not create a pid file.

Instead of running PyMSNt.py directly, it should run a shell script that invokes
twistd with a .tac file, as IIRC the official source tarball does (unfortunately
that seems to be unavailable atm). twistd will create the pid file.

Comment 4 Peter Berry 2006-07-27 16:04:01 UTC

Sigh. Ignore the above comments - I was assuming pymsnt still used twistd, which
for some reason appears not to be the case.

Comment 5 Brian Pepple 2006-09-09 14:25:52 UTC

You should be able to simplify the %files section, since python packages no
longer ghost *.pyo files.

http://fedoraproject.org/wiki/Packaging/Python#head-e48d83dfeb5e671e2018d361d6e75d7e6c6e519c