Bug 1978574
Summary: | allocpages fails silently on arch without NUMA (s390x) | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 8 | Reporter: | smitterl |
Component: | libvirt | Assignee: | Michal Privoznik <mprivozn> |
Status: | CLOSED ERRATA | QA Contact: | smitterl |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | 8.5 | CC: | bfu, bugproxy, dhorak, dzheng, jdenemar, jinzhao, jomiller, jsuchane, max.bender1, mprivozn, thuth, tstaudt, virt-maint, virt-qe-z |
Target Milestone: | rc | Keywords: | Triaged, Upstream |
Target Release: | 8.6 | ||
Hardware: | s390x | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | libvirt-7.8.0-1.module+el8.6.0+12978+7d7a0321 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2022-05-10 13:20:14 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | 7.7.0 |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1916117 |
Description
smitterl
2021-07-02 08:24:34 UTC
Sebastian, I couldn't reproduce. After 'virsh allocpages' I can see them allocated: # virsh allocpages 1MiB 10; virsh freepages --all Node 0: 4KiB: 33392 1024KiB: 10 I've used current git master. Can you please attach debug logs so that I can take a look? (In reply to Michal Privoznik from comment #1) > Sebastian, I couldn't reproduce. After 'virsh allocpages' I can see them > allocated: > > # virsh allocpages 1MiB 10; virsh freepages --all > > Node 0: > 4KiB: 33392 > 1024KiB: 10 > > I've used current git master. Can you please attach debug logs so that I can > take a look? Hi Michal, sure. Attaching log for 'virsh allocpages 1MiB 10'. This reproduces on Alpha Refresh compose, libvirt-daemon-7.6.0-1.module+el8.5.0+12097+2c77910b.s390x kernel kernel-4.18.0-330.el8.s390x # virsh allocpages 1MiB 10 >> empty output # echo $? 0 (BTW, freepages somewhat correctly reports "error: internal error: NUMA isn't available on this host") Alright, I was finally able to reproduce. The problem is that libvirt isn't build with numactl on s390. And I remember writing code that handles that situation but apparently it did not run. Let me try to fix it. Patches posted upstream: https://listman.redhat.com/archives/libvir-list/2021-August/msg00577.html Merged upstream as: c71a986e9a rpm: Enable numactl on s390x 78d4c12b8c virhostmem: Handle numactl-less build in hugepages allocation/reporting ebec3de97d virhostmem: Let caller pass max NUMA node to virHostMemAllocPages 59e3584f71 virhostmem: Let caller pass max NUMA node to virHostMemGetFreePages 20816cbda5 conf: Introduce virCapabilitiesHostNUMAGetMaxNode() v7.6.0-247-gc71a986e9a Bulk update: Move RHEL-AV bugs to RHEL8. A clone for RHEL9 was not created since the target is for s390x, if resolution/testing needs to occur for RHEL9, then a clone must be created. ------- Comment From tstaudt.com 2021-09-13 03:58 EDT------- From IBM's perspective, this should also be implemented for RHEL 9 to avoid regressions. Since RHEL 9.0 contains libvirt-7.6.0-2.el9.src.rpm 2021-Aug-19 12:53 8.3M as of NB 2021/09/01 this seems to be included already though. Please confirm or advise. Thanks. As far as I can see, RHEL 9.0 will be fixed by a rebased version automatically, so from a developers point of view, this will be a no-op there. Sebastian, what about the testing side, do you want to re-test this in RHEL 9.0 ? If so, could you please create a TestOnly clone of this BZ for RHEL 9.0 ? Otherwise, I think we should be fine without a clone. Thank you Thomas. I believe there's no need to have an explicit RHEL 9 item for the following reason: An automated test will be added to the AT suite in this item. The same AT suite will run for RHEL 9, so there should be no need to have an explicit BZ for it. QE will have this as part of our scoping explicitly though. CC Boqiao and Jing for visibility auto test case: https://github.com/autotest/tp-libvirt/pull/3915 Verified with: libvirt-7.9.0-1.module+el8.6.0+13150+28339563.s390x Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: virt:rhel and virt-devel:rhel security, bug fix, and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2022:1759 |