Bug 197872
| Summary: | yum forgets to log | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michal Jaegermann <michal> | ||||||||
| Component: | yum | Assignee: | Jeremy Katz <katzj> | ||||||||
| Status: | CLOSED UPSTREAM | QA Contact: | |||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | rawhide | CC: | bkearney, katzj | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2006-07-10 23:40:24 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 150224 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Michal Jaegermann
2006-07-06 20:00:05 UTC
Indeed -- this is likely a side effect of replacing all the logging code. Adding jbowes to the cc list Created attachment 132073 [details]
Get logging working for files and syslog
Yeah, this is from the new logging. The attached patch gets things working,
however it displays 'Installed' messages twice, but 'Erased' messages only
once. I'm not sure what that is from.
Created attachment 132079 [details]
The cruft free patch
Here is the proper patch. The previous one contained extra cruft.
Indeed, after applying a patch from comment #3 yum starts logging again. Also I can observe as well that both for 'Installed' _and_ 'Updated' entries yum now is "seeing double" although not for 'Erased'. Maybe this is a false track but a quick grep through .py from yum shows that a string 'Erased' shows only in yum-cli/callback.py file, even if in two different places, while 'Installed' and 'Updated' are there and also in yum-cli/output.py. Try rpm -ql yum |grep '\.py$' |xargs grep -l "'Erased'" and similar to see for yourself. Ok, a suggestion from comment #5 is a false track. After slight string modifications it is obvious that all log entries are printed from yum-cli/callback.py. OTOH updating a bigger number of packages at once I see that there is a time difference in "doubled" log entries. It ranges from roughly 30 seconds to over 2 minutes. This suggests that for every package a log entry is produced probably at the installation start and the second time likely after a cleanup phase was finished. (In reply to comment #6) > Ok, a suggestion from comment #5 is a false track. After slight string > modifications it is obvious that all log entries are printed from > yum-cli/callback.py. OTOH updating a bigger number of packages at Yeah. In fact, both install messages come from line 142. Removed messages come from line 197. > once I see that there is a time difference in "doubled" log entries. > It ranges from roughly 30 seconds to over 2 minutes. This suggests > that for every package a log entry is produced probably at > the installation start and the second time likely after a cleanup phase > was finished. Looks like it's actually the test transaction that prints out the first message, and the actual transaction that does the second. I seem to have neglected to let test transactions not produce any output... Created attachment 132182 [details]
Log to syslog and a file, and don't repeat entries.
This patch contains the code from previous patches, and turns on filtering
logging output on the RPM callback based on the output boolean flag passed in.
I applied a patch from comment #8 to my copy of yum and AFAICT it logs and it does not "stutter" for 'Installed', 'Updated' or 'Erased'. okay - I'll grab that patch and apply. Seth applied this upstream and we should do a 2.9.3 "soon" which will have the fix. |