Bug 1978904

Summary:	Review Request: rust-just - A command runner
Product:	[Fedora] Fedora	Reporter:	Olivier Lemasle <o.lemasle>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	casey, eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-07-15 01:04:04 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1978900, 1978902, 1978985, 1978986
Bug Blocks:

Description Olivier Lemasle 2021-07-03 10:59:26 UTC

Spec URL: https://olem.fedorapeople.org/reviews/rust-just.spec
SRPM URL: https://olem.fedorapeople.org/reviews/rust-just-0.9.6-1.fc34.src.rpm

Description:
just is a handy way to save and run project-specific commands.

Fedora Account System Username: olem

Comment 1 Olivier Lemasle 2021-07-03 11:04:28 UTC

Tests are disabled because they depend on internal unpublished crate. I wonder if I should instead try to convince upstream to publish the test crate.

Comment 2 casey 2021-07-03 19:10:10 UTC

Thank you for packaging this!

(In reply to Olivier Lemasle from comment #1)
> Tests are disabled because they depend on internal unpublished crate. I
> wonder if I should instead try to convince upstream to publish the test
> crate.

What error are you getting when you try to run the tests? Is the crate in question the `test-utilities` crate?

Comment 3 Olivier Lemasle 2021-07-03 20:19:31 UTC

Hi casey "upstream" :-)

Yes, I'm referring to the `test-utilities` crate.

As Fedora rust packages are built from the crate source (as downloaded from crates.io), running tests in the Fedora build process requires the availability of the dev-dependencies, hence having `test-utilities` itself published on crates.io.

Comment 4 Olivier Lemasle 2021-07-03 20:21:15 UTC

(or the inclusion of the test utilities into the main `just` crate, to make it self-contained)

Comment 5 casey 2021-07-03 21:44:42 UTC

(In reply to Olivier Lemasle from comment #3)
> Hi casey "upstream" :-)

^_^

> Yes, I'm referring to the `test-utilities` crate.
> 
> As Fedora rust packages are built from the crate source (as downloaded from
> crates.io), running tests in the Fedora build process requires the
> availability of the dev-dependencies, hence having `test-utilities` itself
> published on crates.io.
>
> (or the inclusion of the test utilities into the main `just` crate, to make
> it self-contained)

Makes sense! I had actually already published most of `test-utilities` to
a crate called `temptree` on crates.io, so removing the rest of it was
pretty easy.

I just published `just` 0.9.7 which no longer contains `test-utilities`:

https://crates.io/crates/just/versions

Comment 6 Olivier Lemasle 2021-07-04 08:39:37 UTC

Thanks Casey!

Package updated:

Spec URL: https://olem.fedorapeople.org/reviews/rust-just.spec
SRPM URL: https://olem.fedorapeople.org/reviews/rust-just-0.9.8-1.fc34.src.rpm

Changelog:

* Sun Jul 04 09:45:37 CEST 2021 Olivier Lemasle <o.lemasle> - 0.9.8-1
- Update to upstream 0.9.8; enable tests
- Add shell completions

Comment 7 Robert-André Mauchin 🐧 2021-07-04 08:41:38 UTC

 - Bump to 0.9.7

 - License ok
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.

Comment 8 Robert-André Mauchin 🐧 2021-07-04 08:56:26 UTC

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.

Comment 9 Olivier Lemasle 2021-07-04 09:16:50 UTC

Thanks for the review(s) Robert-André!

https://pagure.io/releng/fedora-scm-requests/issue/35477

Comment 10 Gwyn Ciesla 2021-07-06 14:56:35 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-just

Comment 11 Fedora Update System 2021-07-06 17:07:12 UTC

FEDORA-2021-fefc5d8b35 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-fefc5d8b35

Comment 12 Fedora Update System 2021-07-06 17:47:50 UTC

FEDORA-2021-2b211e977d has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-2b211e977d

Comment 13 Fedora Update System 2021-07-07 01:16:01 UTC

FEDORA-2021-2b211e977d has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-2b211e977d \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-2b211e977d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2021-07-15 01:04:04 UTC

FEDORA-2021-2b211e977d has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.