Bug 1979052

Summary:	Move and rename the 'Export' button
Product:	[oVirt] ovirt-engine	Reporter:	Arik <ahadas>
Component:	ovirt-engine-ui-extensions	Assignee:	Sharon Gratch <sgratch>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Avihai <aefrat>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.4.7	CC:	bugs, patrick.lomakin, sgratch
Target Milestone:	ovirt-4.5.0	Keywords:	ZStream
Target Release:	4.5.0	Flags:	pm-rhel: ovirt-4.5? sgratch: planning_ack? sgratch: devel_ack+ pm-rhel: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-ui-extensions-1.3.1-1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-04-28 09:26:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	UX	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Arik 2021-07-04 14:45:39 UTC

There is a button above the grid of virtual machines named "Export" that exports the selected VM(s) to a data domain.

The problem with this button is twofold:
1. It is named "Export" although there are other export operations (export to OVA and the deprecated export to an export domain). It should have been called "Export to Data Domain" in order to clarify what type of export it means.
2. The other export operations appear in the kebab menu as they are not so common. This operation is even less common than the other export operations and therefore should be in that kebab menu as well, ideally placed next to them

Comment 1 Benny Zlotnik 2021-07-05 11:51:27 UTC

When this was developed it wasn't possible to place buttons that are added via ui-extensions in the kebab menu, Sharon is it possible to this now?

Comment 2 Sharon Gratch 2021-07-14 08:35:27 UTC

(In reply to Benny Zlotnik from comment #1)
> When this was developed it wasn't possible to place buttons that are added
> via ui-extensions in the kebab menu, Sharon is it possible to this now?

No, it's still not supported but if needed then we can check how feasible it is to do that.

Comment 3 Sharon Gratch 2021-07-15 15:45:53 UTC

Benny, 
I checked that and it seems a very easy fix for supporting.
Once the ActionButtonInterface::isInMoreMenu() [1] is set to True then the button is relocated within the kebab menu of the level set by the getPluginApi()..addMenuPlaceActionButton().

So it is supported by the plugin, just need to support that by ui-extensions as well.

 [1] https://github.com/oVirt/ovirt-engine/blob/fe1335ee2d891adb231f7f0e651f6bf0ce3a983b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/ActionButtonInterface.java#L60 

You can either re-assign this bug to UX team and we can handle this for 4.4.9 or if you prefer it earlier then leave that on Storage.

Comment 4 Patrick 2021-08-04 20:27:24 UTC

I think it would be better if we keep one button with the name "Export" and put all the possible export options in the kebab-menu

Comment 5 Arik 2021-08-05 07:51:03 UTC

(In reply to Patrick from comment #4)
> I think it would be better if we keep one button with the name "Export" and
> put all the possible export options in the kebab-menu

If we have one button named "Export" then I would expect it to open a dialog like we have for "Import" that allows the user to choose the target type inside and there would be no need for the other buttons - but that change would take significantly more time

Comment 8 Sandro Bonazzola 2022-04-28 09:26:34 UTC

This bugzilla is included in oVirt 4.5.0 release, published on April 20th 2022.

Since the problem described in this bug report should be resolved in oVirt 4.5.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.