Bug 1979096

Hi Jaroslav,

Spec file is correct. The only issue is with the license.

- Some macro (m4) files are GPLv3+, so spec License should reflect both GPLv2+ and GPLv3+
- There are many GPL references, including the COPYING file, that have the incorrect FSF address. This gives an error in rpmlint:

  tlf.x86_64: E: incorrect-fsf-address /usr/share/licenses/tlf/COPYING

Would it be possible for you to update upstream and add the patch downstream in the spec?

Fix these two issues and review is done.



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU General Public License, Version
     2", "[generated file]", "FSF Unlimited License (with Retention)
     [generated file]", "GNU General Public License v2.0 or later
     [generated file]", "GNU General Public License v3.0 or later", "FSF
     Unlimited License [generated file]", "Expat License [generated file]",
     "GNU General Public License", "FSF All Permissive License", "*No
     copyright* GNU General Public License v2.0 or later", "GNU General
     Public License v2.0 or later [obsolete FSF postal address (Temple
     Place)]", "GNU General Public License [obsolete FSF postal address
     (Temple Place)]". 129 files have unknown license. Detailed output of
     licensecheck in /tmp/tlf/1979096-tlf/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 296960 bytes in 13 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: tlf-1.4.1-1.fc35.x86_64.rpm
          tlf-debuginfo-1.4.1-1.fc35.x86_64.rpm
          tlf-debugsource-1.4.1-1.fc35.x86_64.rpm
          tlf-1.4.1-1.fc35.src.rpm
tlf.x86_64: W: spelling-error %description -l en_US ncurses -> nurses, curses, n curses
tlf.x86_64: W: spelling-error %description -l en_US keyer -> keyed, Meyer, Beyer
tlf.x86_64: W: spelling-error %description -l en_US hamradio -> ham radio, ham-radio, radiogram
tlf.x86_64: E: incorrect-fsf-address /usr/share/licenses/tlf/COPYING
tlf.x86_64: W: no-manual-page-for-binary play_vk
tlf.x86_64: W: no-manual-page-for-binary soundlog
tlf.src: W: spelling-error %description -l en_US ncurses -> nurses, curses, n curses
tlf.src: W: spelling-error %description -l en_US keyer -> keyed, Meyer, Beyer
tlf.src: W: spelling-error %description -l en_US hamradio -> ham radio, ham-radio, radiogram
4 packages and 0 specfiles checked; 1 errors, 8 warnings.




Rpmlint (debuginfo)
-------------------
Checking: tlf-debuginfo-1.4.1-1.fc35.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Source checksums
----------------
https://github.com/Tlf/tlf/releases/download/tlf-1.4.1/tlf-1.4.1.tar.gz.sig :
  CHECKSUM(SHA256) this package     : 05f32587908e74bfe7e1dd6afd1542c6c8147f122d88e354cd9f8c0a1da5c964
  CHECKSUM(SHA256) upstream package : 05f32587908e74bfe7e1dd6afd1542c6c8147f122d88e354cd9f8c0a1da5c964
https://github.com/Tlf/tlf/releases/download/tlf-1.4.1/tlf-1.4.1.tar.gz :
  CHECKSUM(SHA256) this package     : 747fc4a6eb3fff8298f84bbc2423fef96d96bd0ba894faaa4bab2432ad6ec275
  CHECKSUM(SHA256) upstream package : 747fc4a6eb3fff8298f84bbc2423fef96d96bd0ba894faaa4bab2432ad6ec275


Requires
--------
tlf (rpmlib, GLIBC filtered):
    /usr/bin/sh
    glibc
    libc.so.6()(64bit)
    libglib-2.0.so.0()(64bit)
    libhamlib.so.4()(64bit)
    libm.so.6()(64bit)
    libncursesw.so.6()(64bit)
    libpanelw.so.6()(64bit)
    libtinfo.so.6()(64bit)
    libxmlrpc.so.3()(64bit)
    libxmlrpc_client.so.3()(64bit)
    libxmlrpc_util.so.4()(64bit)
    rtld(GNU_HASH)

tlf-debuginfo (rpmlib, GLIBC filtered):

tlf-debugsource (rpmlib, GLIBC filtered):



Provides
--------
tlf:
    tlf
    tlf(x86-64)

tlf-debuginfo:
    debuginfo(build-id)
    tlf-debuginfo
    tlf-debuginfo(x86-64)

tlf-debugsource:
    tlf-debugsource
    tlf-debugsource(x86-64)



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 1979096
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, C/C++, Shell-api
Disabled plugins: fonts, R, Haskell, Python, Perl, PHP, Ocaml, SugarActivity, Java
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Thanks for the review, new version:
Spec URL: https://jskarvad.fedorapeople.org/tlf/tlf.spec
SRPM URL: https://jskarvad.fedorapeople.org/tlf/tlf-1.4.1-2.fc33.src.rpm

Hi Jaroslav,

New spec fails to build due to missing autoconf & automake:

----------------------------------------------------------------------
 Tlf Version 1.4.1 configuration:
 Prefix         /usr
 Preprocessor   gcc -E 
 C Compiler     gcc -O2  -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64  -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection
 Package features:
 With XML RPC   true
-----------------------------------------------------------------------
+ /usr/bin/make -O -j8 V=1 VERBOSE=1
CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh /builddir/build/BUILD/tlf-1.4.1/missing autoconf
/builddir/build/BUILD/tlf-1.4.1/missing: line 81: autoconf: command not found
WARNING: 'autoconf' is missing on your system.
         You should only need it if you modified 'configure.ac',
         or m4 files included by it.
         The 'autoconf' program is part of the GNU Autoconf package:
         <https://www.gnu.org/software/autoconf/>
         It also requires GNU m4 and Perl in order to run:
         <https://www.gnu.org/software/m4/>
         <https://www.perl.org/>
make: *** [Makefile:400: configure] Error 127
make: *** Waiting for unfinished jobs....
/builddir/build/BUILD/tlf-1.4.1/missing: line 81: automake-1.16: command not found
WARNING: 'automake-1.16' is missing on your system.
         You should only need it if you modified 'Makefile.am' or
         'configure.ac' or m4 files included by 'configure.ac'.
         The 'automake' program is part of the GNU Automake package:
         <https://www.gnu.org/software/automake>
         It also requires GNU Autoconf, GNU m4 and Perl in order to run:
         <https://www.gnu.org/software/autoconf>
         <https://www.gnu.org/software/m4/>
         <https://www.perl.org/>
make: *** [Makefile:374: Makefile.in] Error 1

And it tries to run that after the configure part, but I was not able to detect what triggers it. 

Did you try to build it? If it's related to the FSF patch, then you can run autoconf before the configure command and add autoconf & automake as BuildRequires until next tarball is released.

It's because the patch touches the autotools files, try the updated version (the same NVR).

(In reply to Jaroslav Škarvada from comment #4)
> It's because the patch touches the autotools files, try the updated version
> (the same NVR).

I.e. re-download the srpm/spec, it should now build OK.

Works fine now. As requested changes have been made, granting fedora-review.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/tlf

FEDORA-2021-bec485dac0 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-bec485dac0

FEDORA-2021-82a827190a has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-82a827190a

FEDORA-2021-bec485dac0 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-bec485dac0 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-bec485dac0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2021-82a827190a has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-82a827190a \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-82a827190a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2021-bec485dac0 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2021-82a827190a has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.