Bug 1979441

Summary:	High Performance VMs always have "VM CPU does not match the cluster CPU Type" warning
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Marcus West <mwest>
Component:	ovirt-engine	Assignee:	Lucia Jelinkova <ljelinko>
Status:	CLOSED ERRATA	QA Contact:	Polina <pagranat>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.4.6	CC:	ahadas, emarcus, ljelinko, mavital
Target Milestone:	ovirt-4.5.0	Keywords:	ZStream
Target Release:	4.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-4.5.0	Doc Type:	Bug Fix
Doc Text:	Previously there was a warning that indicates the VM CPU is different than the cluster CPU for high performance virtual machines. With this release, the warning is not shown when CPU passthrough is configured, and as a result, not presented for high performance virtual machines.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-05-26 16:22:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Marcus West 2021-07-06 04:10:34 UTC

## Description of problem:

When configuring a VM to be High Performance, the VM tab always shows a warning for that VM "VM CPU does not match the cluster CPU Type"

## Version-Release number of selected component (if applicable):
ovirt-engine-4.4.3.12-0.1.el8ev.noarch

## How reproducible:
Always

## Steps to Reproduce:
1. Create a VM
2. Edit VM and set as "High Performance"
3. Check VM status in the 'Virtual Machines" tab

## Actual results:

VM shows '!' and when you hover over it, it says "The VM CPU does not match the Cluster CPU Type."

## Expected results:

VM not to show any warnings.

## Additional info:

Since High Performance enables CPU host-passthough, it's unlikely that the CPU model/flags will match the 'generic' one used for the cluster, so this message inevitable.

Comment 3 Arik 2021-07-06 10:51:44 UTC

(In reply to Marcus West from comment #0)
> ## Actual results:
> 
> VM shows '!' and when you hover over it, it says "The VM CPU does not match
> the Cluster CPU Type."
> 
> ## Expected results:
> 
> VM not to show any warnings.

The reason for showing this warning is to let the user know that since the CPU of the VM doesn't match that of the cluster, it's less likely that the VM could migrate to other hosts in the cluster.
Now I see that if you use CPU passthough then you should be aware that the CPU won't match that of the cluster. Same story when setting a custom CPU.
But still, the warning should apply.
I guess we argue about the warning in case the VM is set as not migrarable.. but if the VM is migratable, I think the warning should remain.
Lucia, what do you think?

Comment 4 Lucia Jelinkova 2021-07-08 12:54:14 UTC

The purpose of the warning is to notify the user that the VM is configured or is running with different CPU than what is configured on the cluster. This could happen if the user sets custom_cpu, host-passthrough or the configuration of the cpu changes between ovirt versions and the vm is still running with the old configuration. I think that it is correct to show the warning even for the HP VMs.

What we could do is to change the messages for different cases - like "VM uses Host CPU Passthrough", "VM uses custom CPU type", "The VM CPU does not match the Cluster CPU Type". That should better indicate that the host passthrough and custom cpu type are valid cases but user should be careful with them.

Comment 5 Arik 2021-07-11 21:36:29 UTC

(In reply to Lucia Jelinkova from comment #4)
> The purpose of the warning is to notify the user that the VM is configured
> or is running with different CPU than what is configured on the cluster.
> This could happen if the user sets custom_cpu, host-passthrough or the
> configuration of the cpu changes between ovirt versions and the vm is still
> running with the old configuration. I think that it is correct to show the
> warning even for the HP VMs.

But if we think about it this way, without correlating it to live migrations, then one can really say that in the first two cases (custom cpu and host-passthrough) the user explicitly asked to use a CPU type that is different than the cluster's CPU so what additional information this warning provides that the user doesn't already know and what should the user do about it

Comment 7 Lucia Jelinkova 2021-07-13 08:06:02 UTC

Yes, if we look at it this way - user chose to use the custom cpu or the host passthrough, we can remove the warning form the vm list for these two cases. It will be still shown for cases when the configuration of the cluster cpu changes.

Note that the warning is also shown on the VM detail page (general tab) - I think it should be still shown there. Maybe as info rather than a warning.

Comment 11 Polina 2022-03-23 18:47:05 UTC

Verified on ovirt-engine-4.5.0.1-602.3fe8f849c244.6.el8ev.noarch

Checked that for High-Performance VMs and VMs with checked Pass-Through Host CPU:

- No cpu warning on the vm list page for vms.
- On VM detail screen it appears as info.

Comment 16 errata-xmlrpc 2022-05-26 16:22:29 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: RHV Manager (ovirt-engine) [ovirt-4.5.0] security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:4711

Comment 17 meital avital 2022-08-01 11:52:04 UTC

Due to QE capacity, we are not going to cover this issue in our automation