Bug 1979785

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=71430874

Hello Davide, package approved. Thanks you for your packaging.

Hirotaka Wakabayashi

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 61440 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
$ rpmlint machineid-1.0.1-1.fc35.x86_64.rpm 
(none): W: unable to init enchant, spellchecking disabled.
(none): W: unable to init enchant, spellchecking disabled.
======================================================================================================================================== rpmlint session starts =======================================================================================================================================
rpmlint: 2.0.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1

machineid.x86_64: E: shared-library-without-dependency-information /usr/bin/machineid
machineid.x86_64: W: no-manual-page-for-binary machineid


$ rpmlint golang-github-denisbrodbeck-machineid-devel-1.0.1-1.fc35.noarch.rpm
(none): W: unable to init enchant, spellchecking disabled.
(none): W: unable to init enchant, spellchecking disabled.
======================================================================================================================================== rpmlint session starts =======================================================================================================================================
rpmlint: 2.0.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1

golang-github-denisbrodbeck-machineid-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/denisbrodbeck/machineid/.goipath
golang-github-denisbrodbeck-machineid-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/denisbrodbeck/machineid/README.md /usr/share/doc/golang-github-denisbrodbeck-machineid-devel/README.md
golang-github-denisbrodbeck-machineid-devel.noarch: W: files-duplicate /usr/share/licenses/golang-github-denisbrodbeck-machineid-devel/LICENSE.md /usr/share/gocode/src/github.com/denisbrodbeck/machineid/LICENSE.md
========================================================================================================= 1 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.0 s ========================================================================================================



$ rpmlint golang-github-denisbrodbeck-machineid-1.0.1-1.fc35.src.rpm 
(none): W: unable to init enchant, spellchecking disabled.
(none): W: unable to init enchant, spellchecking disabled.
======================================================================================================================================== rpmlint session starts =======================================================================================================================================
rpmlint: 2.0.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1

========================================================================================================= 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.4 s ========================================================================================================



Source checksums
----------------
https://github.com/denisbrodbeck/machineid/archive/v1.0.1/machineid-1.0.1.tar.gz :
  CHECKSUM(SHA256) this package     : 0a01d2b131419cb2b9f7d910a2c90b824449bd91005b47efb235dc707665337a
  CHECKSUM(SHA256) upstream package : 0a01d2b131419cb2b9f7d910a2c90b824449bd91005b47efb235dc707665337a


Requires
--------
machineid (rpmlib, GLIBC filtered):

golang-github-denisbrodbeck-machineid-devel (rpmlib, GLIBC filtered):
    go-filesystem

golang-github-denisbrodbeck-machineid-debugsource (rpmlib, GLIBC filtered):



Provides
--------
machineid:
    machineid
    machineid(x86-64)

golang-github-denisbrodbeck-machineid-devel:
    golang(github.com/denisbrodbeck/machineid)
    golang-github-denisbrodbeck-machineid-devel
    golang-ipath(github.com/denisbrodbeck/machineid)

golang-github-denisbrodbeck-machineid-debugsource:
    golang-github-denisbrodbeck-machineid-debugsource
    golang-github-denisbrodbeck-machineid-debugsource(x86-64)



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 1979785
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: R, Python, SugarActivity, PHP, Ocaml, C/C++, fonts, Perl, Haskell, Java
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Thanks!

$ fedpkg request-repo golang-github-denisbrodbeck-machineid 1979785
https://pagure.io/releng/fedora-scm-requests/issue/36304

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-denisbrodbeck-machineid