Bug 197981
Summary: | Review Request: gkrellm-wifi - Wireless monitor plugin for the GNU Krell Monitors | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Hans de Goede <hdegoede> |
Component: | Package Review | Assignee: | Ville Skyttä <scop> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-07-19 21:56:57 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 197967 | ||
Bug Blocks: | 163779 |
Description
Hans de Goede
2006-07-07 20:07:22 UTC
Note 2: I'm going on a short vacation from monday 10 juli till friday 14 juli, so if I'm quiet thats why. Blockers: - Tarball is not upstream one, sha1sums: package: 52d13482f7ea71ca0f5613ac5209cbe7d8385f42 upstream: 45888e68822189bedb11e3d77e6d5e8eacb6d507 There are also substantial differences in their contents. - Missing dependency on gkrellm. Other notes/suggestions: - Add back "ExcludeArch: s390 s390x" like it was kind of in the FC package for benefit of folks who rebuild FE packages for example for RHEL. - A patch/sed one liner replacing unwanted stuff in CFLAGS with $RPM_OPT_FLAGS could be easier to maintain than copy-pasting all flags between Makefile and the specfile. (In reply to comment #2) > Blockers: > - Tarball is not upstream one, sha1sums: > package: 52d13482f7ea71ca0f5613ac5209cbe7d8385f42 > upstream: 45888e68822189bedb11e3d77e6d5e8eacb6d507 > There are also substantial differences in their contents. Your right, strange, I took the tarbal straight from the core SRPM, it seems the one in core is newer / completer then the upstream one. I've gone back to a pristine upstream tarbal, with the changes found in the core package in a patch. I've also mailed upstream for an explanation on the 2 different 0.9.12 versions. > - Missing dependency on gkrellm. > - Add back "ExcludeArch: s390 s390x" like it was kind of in the FC package > for benefit of folks who rebuild FE packages for example for RHEL. Both fixed > - A patch/sed one liner replacing unwanted stuff in CFLAGS with $RPM_OPT_FLAGS > could be easier to maintain than copy-pasting all flags between Makefile > and the specfile. I'm used to doing things like this for non autotooled packages, so I'm keeping it this way. New version here: Spec URL: http://people.atrpms.net/~hdegoede/gkrellm-wifi.spec SRPM URL: http://people.atrpms.net/~hdegoede/gkrellm-wifi-0.9.12-2.src.rpm Changes: * Mon Jul 17 2006 Hans de Goede <j.w.r.degoede> 0.9.12-2 - Use pristine upstream source and put changes found in the Core package tarbal in a patch - Require gkrellm >= 2.2, gkrellm < 3 - Add ExcludeArch: s390 s390x 0.9.12-2 approved. Thanks! Imported and build, closing. For the record here is the reply I got from upstream about the 2 different versions:
---
Hi,
On Mon, Jul 17, 2006 at 02:07:09PM +0200, Hans de Goede wrote:
> > The one in the core package seems to be newer. I've attached a patch
> > which upgrades the version on your website to this newer version, and
> > thus shows the differences.
> >
> > Do you know how this is possible?
That's very odd indeed - I have no idea how it happened. However, I
don't use Linux nor GKrellM anymore since I've switched to FreeBSD, so
I wont be making any updates to the sources. You're free to take over
maintaining the plug-in if you'd like.
Regards,
Brix
-- Henrik Brix Andersen <henrik>
|