Bug 1980661
| Summary: | "Screen Lock disabled" notification appears on first login after disabling gdm and notification pop-up. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Vishal Pakolu <vpakolu> | ||||
| Component: | gnome-shell | Assignee: | Florian Müllner <fmuellner> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Michal Odehnal <modehnal> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 8.2 | CC: | ayadav, fmuellner, jadahl, sbarcomb, tpelka | ||||
| Target Milestone: | beta | Keywords: | Triaged | ||||
| Target Release: | --- | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | gnome-shell-3.32.2-37.el8 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2021-11-09 19:34:38 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Vishal Pakolu
2021-07-09 07:36:31 UTC
> Notification should not be visible after
After disabling notifications?
I'm a bit confused, because the summary says that the step to disable notifications is optional.
FWIW, I think that this is the issue that was fixed in https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1511 upstream. However I'll wait for confirmation before adding devel+. @Florian : Sorry for the confusion. The issue is reproducible both with notification pop-up disabled and enabled. Also, the issue is reported here upstream > https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2432 (In reply to Vishal Pakolu from comment #3) > @Florian : > > Sorry for the confusion. The issue is reproducible both with notification > pop-up disabled and enabled. > > Also, the issue is reported here upstream > > https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2432 Mmh, I'm still confused. I can backport the fix from that bug, but: > Following Notification is seen on first login : > > "Screen lock is disabled Screen locking requires the GNOME display manager." That is the expected behavior, with or without that patch. What the upstream fix changes is that the notification is only shown once after disabling GDM, instead of at each login. Again, I cannot fix anything if I don't know what I'm supposed to fix in the first place. (In reply to Florian Müllner from comment #4) > (In reply to Vishal Pakolu from comment #3) > > @Florian : > > > > Sorry for the confusion. The issue is reproducible both with notification > > pop-up disabled and enabled. > > > > Also, the issue is reported here upstream > > > https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2432 > > Mmh, I'm still confused. I can backport the fix from that bug, but: > > > Following Notification is seen on first login : > > > > "Screen lock is disabled Screen locking requires the GNOME display manager." > > That is the expected behavior, with or without that patch. What the upstream > fix changes is that the notification is only shown once after disabling GDM, > instead of at each login. It seems this fix is already there is RHEL8.4. I am seeing the notification only once after the vnc service restart. If I relogin into the vnc session, I am not seeing the notification for the subsequent logins. It seems the customer is using RHEL8.2. I have not checked it on RHEL8.2. @Florian So, As per my understanding it is not possible to completely disable this notification. But we can reduced it's frequency. Is it correct? > > Again, I cannot fix anything if I don't know what I'm supposed to fix in the > first place. (In reply to amit yadav from comment #5) > It seems this fix is already there is RHEL8.4. No, it's not. Note that in the context of the notification, "login" refers to the GNOME session. If that session keeps running when vnc disconnects, and further vnc logins reconnect to the existing GNOME session, then it is expected that the notification isn't shown. What the upstream fix for https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2432 does is that gnome-shell remembers that the notification was shown, and will not show it again the next time the (GNOME) session is started without gdm. So is this something you want backported? > @Florian So, As per my understanding it is not possible to completely > disable this notification. > But we can reduced it's frequency. Is it correct? That is what #2432 does. https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1511 also makes sure the `show-banners` setting in `org.gnome.desktop.notifications` is respected. We can backport that as well if desired. (In reply to Florian Müllner from comment #7) > (In reply to amit yadav from comment #5) > > > It seems this fix is already there is RHEL8.4. > > No, it's not. Note that in the context of the notification, "login" refers > to the GNOME session. If that session keeps running when vnc disconnects, > and further vnc logins reconnect to the existing GNOME session, then it is > expected that the notification isn't shown. > > What the upstream fix for > https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2432 does is that > gnome-shell remembers that the notification was shown, and will not show it > again the next time the (GNOME) session is started without gdm. > > So is this something you want backported? > > > @Florian So, As per my understanding it is not possible to completely > > disable this notification. > > But we can reduced it's frequency. Is it correct? > > That is what #2432 does. > https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1511 also makes > sure the `show-banners` setting in `org.gnome.desktop.notifications` is > respected. We can backport that as well if desired. Yes, it would be nice to backport them both to RHEL8. Automation suite was run with good result - no unexpected fails and I was unable to reproduce the issue with the new version. Switching to Verified:Tested. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: GNOME security, bug fix, and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2021:4381 |