Bug 198089
| Summary: | Review Request: padevchooser: Control applet for PulseAudio | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pierre Ossman <pierre-bugzilla> |
| Component: | Package Review | Assignee: | Brian Pepple <bdpepple> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | davidf, lkundrak, lpoetter |
| Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-09-09 18:07:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 195221 | ||
| Bug Blocks: | 163779 | ||
|
Description
Pierre Ossman
2006-07-09 12:00:56 UTC
Spec URL: http://homes.drzeus.cx/~drzeus/pulseaudio/padevchooser.spec SRPM URL: http://homes.drzeus.cx/~drzeus/pulseaudio/padevchooser-0.9.3-1.src.rpm Couple of quick note:
1. You have an ownership problem with the '%{_datadir}/padevchooser' directory.
2. Your missing a BR on desktop-file-utils.
Spec URL: http://homes.drzeus.cx/~drzeus/pulseaudio/padevchooser.spec SRPM URL: http://homes.drzeus.cx/~drzeus/pulseaudio/padevchooser-0.9.3-2.src.rpm MD5Sums:
6a9b52ad349f3fb3d5a3ccdf85958710 padevchooser-0.9.3.tar.gz
Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* All directories are owned by this or other packages
* All necessary BuildRequires listed.
* All desired features are enabled
* Make succeeds even when %{_smp_mflags} is defined
* Package builds in Mock.
* rpmlint produces no errors.
Minor:
* Duplicate BuildRequires: gtk2-devel (provided by libglade2-devel)
+1 Approve
Package Change Request ====================== Package Name: padevchooser Updated Fedora Owners: lpoetter,drzeus-bugzilla I am upstream of this package and Pierre agreed to co-maintain this package with me from now on. CVS done. Maintainer is OK with the change as per previous conversation with him. Package Change Request ====================== Package Name: padevchooser New Branches: EL-5 Owners for new branch: lkundrak cvsextras commits for new branch: yes cvs done. |