Bug 1981110 (rust-cpufeatures)

Taking this review.

Looks like you'll need to add something like "ExclusiveArch: x86_64 aarch64".
The crate does not compile on other architectures, and should also not be used on other architectures.

Alternatively, you could do something like what was done in the rust-cpuid-bool package for the same situation:
https://src.fedoraproject.org/rpms/rust-cpuid-bool/blob/rawhide/f/rust-cpuid-bool.spec

Additionally, It would be great to use the changelog timestamp format without time and timezone.
rust2rpm >= 18 will do that by default again.

(In reply to Fabio Valentini from comment #1)
> Taking this review.
> 
> Looks like you'll need to add something like "ExclusiveArch: x86_64 aarch64".
> The crate does not compile on other architectures, and should also not be
> used on other architectures.
> 
This gonna restrict significantly the reach of dependent packages :(

> Alternatively, you could do something like what was done in the
> rust-cpuid-bool package for the same situation:
> https://src.fedoraproject.org/rpms/rust-cpuid-bool/blob/rawhide/f/rust-cpuid-
> bool.spec
> 
> Additionally, It would be great to use the changelog timestamp format
> without time and timezone.
> rust2rpm >= 18 will do that by default again.

I've reverted itt in my script, but I plqn to move to rpmautospec for all new and updated packages.

New Spec URL: https://eclipseo.fedorapeople.org/for-review/rust-cpufeatures.spec
New SRPM URL: https://eclipseo.fedorapeople.org/for-review/rust-cpufeatures-0.1.5-1.fc35.src.rpm

Thanks for the review!

(In reply to Robert-André Mauchin 🐧 from comment #2)
> (In reply to Fabio Valentini from comment #1)
> > Taking this review.
> > 
> > Looks like you'll need to add something like "ExclusiveArch: x86_64 aarch64".
> > The crate does not compile on other architectures, and should also not be
> > used on other architectures.
> > 
> This gonna restrict significantly the reach of dependent packages :(

It won't. Or at least, it shouldn't.
For example, looking at for example sha-1, the cpufeatures dependency is scoped to x86_64 and aarch64, as well,
same as the cpuid-bool dependency was before it in older versions.
If the dependency is not scoped by target architecture in some crates, then that's a bug. :)

> > Alternatively, you could do something like what was done in the
> > rust-cpuid-bool package for the same situation:
> > https://src.fedoraproject.org/rpms/rust-cpuid-bool/blob/rawhide/f/rust-cpuid-
> > bool.spec
> > 
> > Additionally, It would be great to use the changelog timestamp format
> > without time and timezone.
> > rust2rpm >= 18 will do that by default again.
> 
> I've reverted itt in my script, but I plqn to move to rpmautospec for all
> new and updated packages.

Works for me.

Package APPROVED

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cpufeatures

FEDORA-2021-9f4d0e6041 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-9f4d0e6041

FEDORA-2021-2f997f6af2 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2021-9f4d0e6041 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-9f4d0e6041`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-9f4d0e6041

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2021-9f4d0e6041 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.