Bug 1982430

Summary: Review Request: python-azure-mgmt-appplatform - Microsoft Azure App Platform Management Client Library for Python
Product: [Fedora] Fedora Reporter: Major Hayden 🤠 <mhayden>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED DEFERRED QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: code, package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-08-20 14:45:31 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Major Hayden 🤠 2021-07-14 19:31:04 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/azure-cli/fedora-rawhide-x86_64/02330188-python-azure-mgmt-appplatform/python-azure-mgmt-appplatform.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/azure-cli/fedora-rawhide-x86_64/02330188-python-azure-mgmt-appplatform/python-azure-mgmt-appplatform-6.1.0-1.fc35.src.rpm
Description: Microsoft Azure App Platform Management Client Library for Python
Fedora Account System Username: mhayden

Note: The three ppp's are very imppportant and that's not a mispppelling there. 😜

Comment 1 Ben Beasley 2021-07-19 13:57:11 UTC
The MIT license requires the copyright statement and license text to be included in copies (https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text). The source file headers reference “License.txt in the project root” but it’s not in the PyPI tarball.

I seem to recall you’ve had to handle this problem in some of the other Azure SDK packages as well.

Comment 2 Major Hayden 🤠 2021-07-19 13:59:37 UTC
Yeah, this is a bit frustrasting. My azure-cli patches for adding licenses was well-received and merged quickly. However, my SDK patch is stalled out. https://github.com/Azure/azure-sdk-for-python/pull/19240#issuecomment-860816715

Comment 3 Major Hayden 🤠 2021-07-19 14:10:53 UTC
I got someone's ear on Twitter, so perhaps something will happen: https://twitter.com/majorhayden/status/1417123844389756933

Comment 4 Major Hayden 🤠 2021-08-02 17:44:06 UTC
Opened a smaller PR upstream to see if it will move faster. https://github.com/Azure/azure-sdk-for-python/pull/20036