Bug 1982631

Summary: Review Request: php-http-promise - Promise used for asynchronous HTTP requests
Product: [Fedora] Fedora Reporter: Christopher Engelhard <ce>
Component: Package ReviewAssignee: Otto Liljalaakso <otto.liljalaakso>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora, otto.liljalaakso, package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-09-19 00:45:31 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 201449, 1982630    

Description Christopher Engelhard 2021-07-15 10:26:28 UTC 
Spec URL: https://download.copr.fedorainfracloud.org/results/lcts/nextcloud/fedora-rawhide-x86_64/02329597-php-http-promise/php-http-promise.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/lcts/nextcloud/fedora-rawhide-x86_64/02329597-php-http-promise/php-http-promise-1.1.0-1.fc35.src.rpm

Description: Promise used for asynchronous HTTP requests.

Since this package is set up to use rpmautospec, rpmlint/fedora-review will complain about missing dist tags & macros in changelog. These are spurious errors/warnings.

This package is available from the lcts/nextcloud Copr, so you can also test it using 'fedora-review --copr-build 2329597'


Fedora Account System Username: lcts
Comment 1 Otto Liljalaakso 2021-08-16 11:34:34 UTC 
Reviewed. These are now fast, as I got a hold of reviewing php libraries.

Findings:

1.
> Autoloader: %{_datadir}/php/%{ns_dir}/autoload.php

Replace with format that cannot be confused with a specfile tag.

2. 
> %if 0%{?with_tests}
> : Run tests
> : No tests implemented
> %endif

There are tests, in the spec/ directory.
Need to use makesrc.sh to include them.

3.
From fedora-review:
> Note: Directories without known owners: /usr/share/php/Http

For package php-leagure-uri-interface,
we agreed to solve similar problem
by sharing the vendor directory ownership
between all packages from that vendor.
I suppose the same solution can be applied here, too?

4.
> URL:            https://github.com/%{gh_vendor}/%{gh_project}

composer.json lists this as http://httplug.io.
Just noting this,
I do not really have clear opinion if it is better
to link to the library source repository
or to umbrella project's homepage.
Comment 2 Package Review 2021-09-19 00:45:31 UTC 
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.