Bug 1982633

Summary: Review Request: php-league-uri - URI manipulation library
Product: [Fedora] Fedora Reporter: Christopher Engelhard <ce>
Component: Package ReviewAssignee: Otto Liljalaakso <otto.liljalaakso>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora, otto.liljalaakso, package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-09-19 00:45:35 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1982635    
Bug Blocks: 201449, 1982651    

Description Christopher Engelhard 2021-07-15 10:31:46 UTC 
Spec URL: https://download.copr.fedorainfracloud.org/results/lcts/nextcloud/fedora-rawhide-x86_64/02329600-php-league-uri/php-league-uri.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/lcts/nextcloud/fedora-rawhide-x86_64/02329600-php-league-uri/php-league-uri-6.4.0-1.fc35.src.rpm

Description: The Uri package provides simple and intuitive classes to manage URIs in PHP. You will be able to parse, build and resolve URIs, create URIs from different sources (string, PHP environment, base URI, URI template, ...), handle internalisation and infer properties and features from URIs.

Since this package is set up to use rpmautospec, rpmlint/fedora-review will complain about missing dist tags & macros in changelog. These are spurious errors/warnings.

This package is available from the lcts/nextcloud Copr, so you can also test it using 'fedora-review --copr-build 2329600'


Fedora Account System Username: lcts
Comment 1 Otto Liljalaakso 2021-08-16 10:14:51 UTC 
Reviewed, findings are:

1. 
> URL:            https://github.com/%{gh_vendor}/%{gh_project}

It is mostly a matter of taste
if project source repository or homepage is used here,
but note that composer.json lists homepage as 
https://uri.thephpleague.com/

You can change this or not, whatever you feel is the best.

2.
> Autoloader: %{_datadir}/php/%{ns_dir}/autoload.php

Say "The library autoloader is:"
to avoid possibility of confusing this with specfile macros.

3.
> %if 0%{?with_tests}
> : Run tests
> : No tests implemented
> %endif

There are tests, so need to use makesrc.sh here.
Comment 2 Package Review 2021-09-19 00:45:35 UTC 
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.