Bug 198277
Summary: | PATCH: libsepol doesnt use CFLAGS every time | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Dennis Gilmore <dennis> | ||||
Component: | libsepol | Assignee: | Daniel Walsh <dwalsh> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | |||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | sdsmall, tcallawa | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2006-08-31 16:05:53 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Dennis Gilmore
2006-07-10 20:14:55 UTC
Created attachment 132194 [details]
have libsepol use CFLAGS always
If you want to pass a flag to the linker, set LDFLAGS. Don't add CFLAGS to the linking command line. Ulrich's guidance was to use -fpic whenever possible, so we wouldn't want to change the default there, but possibly we should put that into its own variable so that you can override it on the make commandline w/o needing to patch the Makefile. sparc64 needs -fPIC only when the GOT size for the linked executable exceeds the maximum machine size (which it does in libsepol). Most other arches will use -fpic happily, so it is a good default. Having a variable that I can override for sparc64 will resolve this issue cleanly. (In reply to comment #2) > If you want to pass a flag to the linker, set LDFLAGS. > Don't add CFLAGS to the linking command line. Yes, but you're not using "ld" to link. You're using gcc. The flags that would be appropriate for ld to link as a sparc64 binary are not the same flags that would be appropriate for gcc.to link a sparc64 binary. CFLAGS is appropriate when you're using gcc, thus, the patch. This has been in rawhide for quite some time. |