Bug 1982805

Summary: [OCS 4.8]Log messages for deprecated types CronJob, PDBs, and CSI driver in Rook-operator pod
Product: [Red Hat Storage] Red Hat OpenShift Container Storage Reporter: Neha Berry <nberry>
Component: rookAssignee: Travis Nielsen <tnielsen>
Status: CLOSED ERRATA QA Contact: Neha Berry <nberry>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.8CC: madam, mbukatov, muagarwa, ocs-bugs
Target Milestone: ---Keywords: ZStream
Target Release: OCS 4.8.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: v4.8.2-179.ci Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-09-29 15:03:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
sample rook-op log none

Description Neha Berry 2021-07-15 18:36:12 UTC 
Created attachment 1801979 [details]
sample rook-op log

Created attachment 1801979 [details]
sample rook-op log

==================================================================
In OCS 4.8(Internal, internal-attached and external modes) , rook operator logs contain a continuous flow of  Log messages for deprecated types : CronJob, PDBs, and CSI driver. These are verbose, hence make the readability of logs difficult. These are already fixed or known in upstream issue.

>>1. CRON job

W0715 13:07:55.522149       7 warnings.go:70] batch/v1beta1 CronJob is deprecated in v1.21+, unavailable in v1.25+; use batch/v1 CronJob


>>2. CSIDriver

W0715 13:04:45.028153       7 warnings.go:70] storage.k8s.io/v1beta1 CSIDriver is deprecated in v1.19+, unavailable in v1.22+; use storage.k8s.io/v1 CSIDriver

>>3. PodDisruptionBudget

W0715 13:04:37.393016       7 warnings.go:70] policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget


Attaching a log for reference.

Sample log from one regression run - http://magna002.ceph.redhat.com/ocsci-jenkins/openshift-clusters/j037bu1cni33-t1/j037bu1cni33-t1_20210712T105828/logs/failed_testcase_ocs_logs_1626095479/test_bucket_delete_with_objects%5bOC-AZURE%5d_ocs_logs/ocs_must_gather/quay-io-rhceph-dev-ocs-must-gather-sha256-64aafeb40cbbd3670845843ab6b9913356c8d32a12754050a404093354ab580c/namespaces/openshift-storage/pods/rook-ceph-operator-7bf69f85dc-xghh9/rook-ceph-operator/rook-ceph-operator/logs/current.log




Version of all relevant components (if applicable):
=======================================================
OCS = ocs-operator.v4.8.0-452.ci and older 4.8 builds
OCP  = 4.8.0-0.nightly-2021-07-09-181248

ceph version 	14.2.11-184.el8cp

Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?
===========================================================================
No

Is there any workaround available to the best of your knowledge?
==================================================================
No

Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?
===============================================================================
2

Can this issue reproducible?
==========================
Yes

Can this issue reproduce from the UI?
==========================================
N/A

If this is a regression, please provide more details to justify this:
======================================================================
Not sure if this is a code change for a feature of 4.8 or a regression

Steps to Reproduce:
====================
1. Install OCS 4.8 in either internal or external mode
2. Check the rook operator logs



Actual results:
==================
Logs flooded with messages about deprecated *** in version ***

Expected results:
========================
These messages should re resolved 


Additional info:
====================
chat discussion with Engineering -  https://chat.google.com/room/AAAAREGEba8/ZvOR52Ti6VA

It was suggested to take this up in 4.8.z release as this is reducing the readability of logs.
Comment 2 Travis Nielsen 2021-07-15 19:06:24 UTC 
The CronJob, PDB, and CSI driver deprecated v1beta1 types are fixed upstream (or soon to be merged) in the attached three PRs, and would already be included in 4.9. Agreed that we really should backport these to 4.8.z so we can reduce the noise in the logs, even if customers don't see a direct issue with them.
Comment 3 Travis Nielsen 2021-08-20 19:27:45 UTC 
The backport PR has been opened for the v1 CronJob and PDB resources: https://github.com/openshift/rook/pull/284
These changes also required pulling in an updated client-go 1.21 and controller runtime 0.9, which may make OCS integration challenging.

The v1 CSI driver updates are completed with https://github.com/openshift/rook/pull/282
Comment 16 errata-xmlrpc 2021-09-29 15:03:28 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenShift Container Storage 4.8.2 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:3695