Bug 1983562

Summary:	Review Request: rust-rctree - A tree implemented using reference counting
Product:	[Fedora] Fedora	Reporter:	Rémi Lauzier <remilauzier>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, eclipseo, package-review, remilauzier
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-04-23 17:39:46 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Rémi Lauzier 2021-07-19 06:02:39 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/remilauzier/rust-simp/fedora-rawhide-x86_64/02333388-rust-rctree/rust-rctree.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/remilauzier/rust-simp/fedora-rawhide-x86_64/02333388-rust-rctree/rust-rctree-0.4.0-1.fc35.src.rpm
Description: A 'DOM-like' tree implemented using reference counting
Fedora Account System Username: remilauzier

Comment 1 Robert-André Mauchin 🐧 2022-01-23 19:39:21 UTC

 - Exclude benches by patching Cargo.toml

exclude = ["tests/*"]

 - License ok
 - Latest version packaged
 - No rpmlint errors
 - Checks pass
 - Conforms to Packaging Guidelines

Please regenerate the .spec file with rust2rpm 20 before building this package for Fedora.

Comment 2 Rémi Lauzier 2022-01-29 06:32:52 UTC

spec: https://download.copr.fedorainfracloud.org/results/remilauzier/rust-simp/fedora-rawhide-x86_64/03259060-rust-rctree/rust-rctree.spec
srpm: https://download.copr.fedorainfracloud.org/results/remilauzier/rust-simp/fedora-rawhide-x86_64/03259060-rust-rctree/rust-rctree-0.4.0-1.fc36.src.rpm

Update. I would like to know how to create a srpm for copr without having a git repo?
each time i do fedpkg srpm, it error. for now i have remove rpmautospec to be able to have a srpm with the patch.

Could not execute srpm: 'NoneType' object has no attribute 'head'

Comment 3 Fabio Valentini 2022-01-30 11:19:04 UTC

> each time i do fedpkg srpm

Don't do this outside dist-git repositories.
Just use "rpmbuild -bs *.spec" instead, it will ignore rpmautospec macros.

Comment 4 Rémi Lauzier 2022-01-30 17:00:52 UTC

Thanks for the info!

spec: https://download.copr.fedorainfracloud.org/results/remilauzier/rust-simp/fedora-rawhide-x86_64/03260370-rust-rctree/rust-rctree.spec
srpm: https://download.copr.fedorainfracloud.org/results/remilauzier/rust-simp/fedora-rawhide-x86_64/03260370-rust-rctree/rust-rctree-0.4.0-1.fc36.src.rpm

Update

Comment 5 Rémi Lauzier 2022-03-22 21:55:42 UTC

Update for rust2rpm 21.

spec: https://download.copr.fedorainfracloud.org/results/remilauzier/rust-simp/fedora-rawhide-x86_64/03813625-rust-rctree/rust-rctree.spec
srpm: https://download.copr.fedorainfracloud.org/results/remilauzier/rust-simp/fedora-rawhide-x86_64/03813625-rust-rctree/rust-rctree-0.4.0-1.fc37.src.rpm

Comment 6 Rémi Lauzier 2022-03-22 21:57:27 UTC

Hi Robert!

When you have time, can you approved this package?

Comment 7 Package Review 2022-04-22 00:45:21 UTC

This is an automatic action taken by review-stats script.

The ticket reviewer failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we reset the status and the assignee of this ticket.