Created attachment 1803339[details]
Patch to remove stack size optimization for the Watchdog thread
This code in js/xpconnect/src/XPCJSContext.cpp fails to build with glibc 2.34:
static constexpr size_t kWatchdogStackSize =
PTHREAD_STACK_MIN < 32 * 1024 ? 32 * 1024 : PTHREAD_STACK_MIN;
I'm not sure to what extent this optimization is important, given that the kernel will not use memory for unused areas of the stack. The use of PTHREAD_STACK_MIN is dubious anyway because the constant only means that pthread_attr_setstack will not fail. It doesn't say that the thread stack is useful for running any application code.
Created attachment 1803339 [details] Patch to remove stack size optimization for the Watchdog thread This code in js/xpconnect/src/XPCJSContext.cpp fails to build with glibc 2.34: static constexpr size_t kWatchdogStackSize = PTHREAD_STACK_MIN < 32 * 1024 ? 32 * 1024 : PTHREAD_STACK_MIN; I'm not sure to what extent this optimization is important, given that the kernel will not use memory for unused areas of the stack. The use of PTHREAD_STACK_MIN is dubious anyway because the constant only means that pthread_attr_setstack will not fail. It doesn't say that the thread stack is useful for running any application code.