Bug 1983901

Summary: [virtio-win][whql test][viostor+vioscsi] job 'Storage HBA Firmware Update' fail
Product: Red Hat Enterprise Linux 8 Reporter: menli <menli>
Component: virtio-winAssignee: Vadim Rozenfeld <vrozenfe>
virtio-win sub component: virtio-win-prewhql QA Contact: menli <menli>
Status: CLOSED CURRENTRELEASE Docs Contact:
Severity: medium    
Priority: high CC: lijin, lmiksik, phou, vrozenfe
Version: 8.5Keywords: TestBlocker
Target Milestone: betaFlags: pm-rhel: mirror+
Target Release: ---   
Hardware: x86_64   
OS: Windows   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-11-23 08:38:15 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1979205    

Description menli@redhat.com 2021-07-20 06:40:16 UTC
Description of problem:
job 'Storage HBA Firmware Update' fail on win2019

Version-Release number of selected component (if applicable):
qemu-kvm-6.0.0-22.module+el8.5.0+11695+95588379.x86_64
kernel-4.18.0-314.el8
virtio-win-prewhql-204


How reproducible:
100%

Steps to Reproduce:
1.boot up Win2019 with virtio-blk device(q35)
2.submit 'Storage HBA Firmware Update' to hlk-1809

Actual results:
job failed

error log:
Error 7/14/2021 11:55:21.245 PM IOCTL_STORAGE_FIRMWARE_GET_INFO - The device does not support firmware upgrade. 
File:   drivers\storage\tests\storfirmware\firmware.cpp Line: 546 
Error Type:   BOOL 
Error Code:   0x0 
Error Text:   Error 0x00000000 
End Test 7/14/2021 11:55:21.247 PM Validate firmware upgrade support information. 
Result:   Fail 
Repro:   StorFirmware -hbatest \\.\PhysicalDrive1 "Enter_Path_and_Name_of_New_Firmware_File" 


Expected results:
job can pass

Additional info:
"Storage Firmware HBA Update" in the lastest job list after load the playlist.(not run this case before)

Comment 2 Peixiu Hou 2021-07-20 10:04:27 UTC
I also hit the same issue with vioscsi driver.

The job 'Storage HBA Firmware Update' failed on win2019 server.
I tried both playlist(10/26/2020) and playlist(7/19/2020), this job both cannot be filterd.

Failed error: 
Start Test 7/19/2021 2:55:28.151 PM Get firmware information by issuing IOCTL_STORAGE_FIRMWARE_GET_INFO. 
Error 7/19/2021 2:55:28.152 PM Get Firmware Information - IOCTL_STORAGE_FIRMWARE_GET_INFO Failed. Error code: 1 
File:   drivers\storage\tests\storfirmware\firmware.cpp Line: 434 
Error Type:   BOOL 
Error Code:   0x0 
Error Text:   Error 0x00000000 
End Test 7/19/2021 2:55:28.152 PM Get firmware information by issuing IOCTL_STORAGE_FIRMWARE_GET_INFO. 
Result:   Fail 
Repro:   StorFirmware -hbatest \\.\PhysicalDrive1 "Enter_Path_and_Name_of_New_Firmware_File" 
 

Used version:
kernel-5.13.0-0.rc7.51.el9.x86_64
qemu-kvm-6.0.0-8.el9.x86_64
seabios-bin-1.14.0-5.el9.noarch
virtio-win-prewhql-204

Thanks~
Peixiu

Comment 14 Vadim Rozenfeld 2021-08-03 08:11:43 UTC
should be fixed in two PRs
https://github.com/virtio-win/kvm-guest-drivers-windows/pull/615 for vioscsi
and
https://github.com/virtio-win/kvm-guest-drivers-windows/pull/616 for viostor

Comment 16 Vadim Rozenfeld 2021-08-05 07:40:54 UTC
please give a try to build 207
https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=1685166

Comment 17 menli@redhat.com 2021-08-05 07:53:30 UTC
Thanks Vadim

Try blk first with 207 still fail with new error :

error log:
Error 8/4/2021 12:37:13.369 PM Unable to open handle for firmware image file Enter_Path_and_Name_of_New_Firmware_File. 
File:   drivers\storage\tests\storfirmware\firmware.cpp Line: 1484 
Error Type:   BOOL 
Error Code:   0x0 
Error Text:   Error 0x00000000 
End Test 8/4/2021 12:37:13.370 PM Download firmware to device using IOCTL_STORAGE_FIRMWARE_DOWNLOAD. 
Result:   Fail 
Repro:   StorFirmware -hbatest \\.\PhysicalDrive1 "Enter_Path_and_Name_of_New_Firmware_File" 

entire hlkx file
http://fileshare.englab.nay.redhat.com/pub/section2/coredump/bug_1983901/

Comment 18 Vadim Rozenfeld 2021-08-05 08:11:20 UTC
Yeah, this is a funny part - "Unable to open handle for firmware image file Enter_Path_and_Name_of_New_Firmware_File. "

The test itself needs to download a new firmware from a file into the device. I was running this test manually (no from HLK studio)
and specifying some andom text file instead. I believe that we need to specifya real file name and path instead of "Enter_Path_and_Name_of_New_Firmware_File"
to pass this test.

Best,
Vadim.

Comment 24 menli@redhat.com 2021-08-09 02:44:53 UTC
Thanks all

Pass this job base comment 23 with virtio-win-prewhql-0.1-207.iso, change status to verified.

Comment 27 Peixiu Hou 2021-08-09 06:26:27 UTC
Hi Vadim,

Tested this job with vioscsi + virtio-win-prewhql-0.1-207, settings are same with comment#23 mentioned, the job can be passed.

Thanks~
Peixiu

Comment 28 Vadim Rozenfeld 2021-08-09 06:54:53 UTC
Menghuan & Peixiu
Thanks a lot for your feedback.
All the best,
Vadim.