Bug 1984303

Summary: "invalid keyword in the devices section: overrides" should be printed when /etc/multipath.conf lack of } in the devices section
Product: Red Hat Enterprise Linux 9 Reporter: Lin Li <lilin>
Component: device-mapper-multipathAssignee: Ben Marzinski <bmarzins>
Status: CLOSED ERRATA QA Contact: Lin Li <lilin>
Severity: high Docs Contact:
Priority: medium    
Version: 9.0CC: agk, bmarzins, heinzm, msnitzer, prajnoha, zkabelac
Target Milestone: betaKeywords: Triaged
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: device-mapper-multipath-0.8.7-1.el9 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-05-17 15:56:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Lin Li 2021-07-21 08:06:14 UTC
Description of problem:
"invalid keyword in the devices section: overrides" should be printed when /etc/multipath.conf lack of } in the devices section

Version-Release number of selected component (if applicable):
device-mapper-multipath-0.8.6-4.el9

How reproducible:
always

Steps to Reproduce:
1.[root@storageqe-05 ~]# rpm -qa | grep multipath
device-mapper-multipath-libs-0.8.6-4.el9.x86_64
device-mapper-multipath-0.8.6-4.el9.x86_64

2.Edit /etc/multipath.conf
defaults {
	user_friendly_names yes
	find_multipaths strict
	enable_foreign "^$"
	find_multipaths_timeout 10
}

blacklist_exceptions {
        property "(SCSI_IDENT_|ID_WWN)"
}

devices {
	device {
		vendor "AIX"
		product "VDASD"
		path_grouping_policy "multibus"
		no_path_retry 60
	}
        overrides {  <----------------------
}

blacklist {
}

3.[root@storageqe-05 ~]# service multipathd reload
Redirecting to /bin/systemctl reload multipathd.service

4.[root@storageqe-05 ~]# multipath -ll
430380.069122 | /etc/multipath.conf line 29, invalid keyword: overrides
360a98000324669436c2b45666c567865 dm-3 NETAPP,LUN
size=2.0G features='3 queue_if_no_path pg_init_retries 50' hwhandler='1 alua' wp=rw
|-+- policy='service-time 0' prio=50 status=active
| |- 1:0:0:0   sdj   8:144    active ready running
| `- 4:0:1:0   sdf   8:80     active ready running
`-+- policy='service-time 0' prio=10 status=enabled
  |- 1:0:1:0   sdn   8:208    active ready running
  `- 4:0:0:0   sdb   8:16     active ready running


Actual results:
multipath reported "invalid keyword: overrides"

Expected results:
multipath report "invalid keyword in the devices section: overrides" or "missing '}'"

Additional info:

Comment 5 Lin Li 2021-11-15 13:52:15 UTC
Verified on device-mapper-multipath-0.8.7-2.el9
1.[root@storageqe-05 ~]# rpm -qa | grep multipath
device-mapper-multipath-libs-0.8.7-2.el9.x86_64
device-mapper-multipath-0.8.7-2.el9.x86_64

2.Edit /etc/multipath.conf
defaults {
	user_friendly_names yes
	find_multipaths strict
	enable_foreign "^$"
	find_multipaths_timeout 10
}

blacklist_exceptions {
        property "(SCSI_IDENT_|ID_WWN)"
}

devices {
	device {
		vendor "AIX"
		product "VDASD"
		path_grouping_policy "multibus"
		no_path_retry 60
	}
        overrides {  <----------------------
}

blacklist {
}

3.[root@storageqe-05 ~]# service multipathd reload
Redirecting to /bin/systemctl reload multipathd.service

4.[root@storageqe-05 ~]# multipath -ll
37837.973995 | /etc/multipath.conf line 30, invalid keyword in the devices section: overrides   <--------------------------------
360a98000324669436c2b45666c567865 dm-3 NETAPP,LUN
size=2.0G features='3 queue_if_no_path pg_init_retries 50' hwhandler='1 alua' wp=rw
|-+- policy='service-time 0' prio=50 status=active
| |- 1:0:0:0 sdb 8:16  active ready running
| `- 4:0:1:0 sdn 8:208 active ready running
`-+- policy='service-time 0' prio=10 status=enabled
  |- 1:0:1:0 sdf 8:80  active ready running
  `- 4:0:0:0 sdj 8:144 active ready running
360a98000324669436c2b45666c567867 dm-4 NETAPP,LUN
size=2.0G features='3 queue_if_no_path pg_init_retries 50' hwhandler='1 alua' wp=rw
|-+- policy='service-time 0' prio=50 status=active
| |- 1:0:0:1 sdc 8:32  active ready running
| `- 4:0:1:1 sdo 8:224 active ready running
`-+- policy='service-time 0' prio=10 status=enabled
  |- 1:0:1:1 sdg 8:96  active ready running
  `- 4:0:0:1 sdk 8:160 active ready running
360a98000324669436c2b45666c567869 dm-5 NETAPP,LUN
size=2.0G features='3 queue_if_no_path pg_init_retries 50' hwhandler='1 alua' wp=rw
|-+- policy='service-time 0' prio=50 status=active
| |- 1:0:0:2 sdd 8:48  active ready running
| `- 4:0:1:2 sdp 8:240 active ready running
`-+- policy='service-time 0' prio=10 status=enabled
  |- 1:0:1:2 sdh 8:112 active ready running
  `- 4:0:0:2 sdl 8:176 active ready running
360a98000324669436c2b45666c56786b dm-6 NETAPP,LUN
size=2.0G features='3 queue_if_no_path pg_init_retries 50' hwhandler='1 alua' wp=rw
|-+- policy='service-time 0' prio=50 status=active
| |- 1:0:0:3 sde 8:64  active ready running
| `- 4:0:1:3 sdq 65:0  active ready running
`-+- policy='service-time 0' prio=10 status=enabled
  |- 1:0:1:3 sdi 8:128 active ready running
  `- 4:0:0:3 sdm 8:192 active ready running



Test result:multipath report "invalid keyword in the devices section: overrides"

Comment 7 errata-xmlrpc 2022-05-17 15:56:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: device-mapper-multipath), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:3971