Bug 1984466

Summary:	Review Request: rubygem-ed25519 - An efficient digital signature library providing the Ed25519 algorithm
Product:	[Fedora] Fedora	Reporter:	Pavel Valena <pvalena>
Component:	Package Review	Assignee:	Jarek Prokop <jprokop>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jprokop, mike, package-review
Target Milestone:	---	Flags:	jprokop: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	rubygem-ed25519-1.3.0-1.fc38	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-10-17 10:19:15 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1962869, 2087076

Description Pavel Valena 2021-07-21 14:00:20 UTC

Spec URL: https://raw.githubusercontent.com/fedora-distgit/rubygem-ed25519/rawhide/rubygem-ed25519.spec
SRPM URL: https://raw.githubusercontent.com/fedora-distgit/rubygem-ed25519/rawhide/rubygem-ed25519-1.2.4-1.fc35.src.rpm
Description: A Ruby binding to the Ed25519 elliptic curve public-key signature system described in RFC 8032.
Fedora Account System Username: pvalena

Koji scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=72309111
COPR build: https://copr.fedorainfracloud.org/coprs/build/2336086

It's supposed to be used with Vagrant:
https://bugzilla.redhat.com/show_bug.cgi?id=1962869
https://gist.github.com/pvalena/a7d0028da78b0e71d54ff3a2e170a138
(I didn't test the integration, but it's installation doesn't break Vagrant.)

Comment 1 Pavel Valena 2022-05-16 18:31:21 UTC

Jarku,
could you take a look at this? It's used by Vagrant.

Comment 2 Jarek Prokop 2022-05-17 06:51:41 UTC

I'll take it for review.

JFYI new version 1.3.0 was released on January 16, 2022.

Comment 3 Jarek Prokop 2022-05-17 08:59:40 UTC

Looking at the commit history, version 1.3.0 does not seem to bring anything relevant for Fedora Ruby (and for the package's functionality) so it's more of a "nice to have" IMO.

* Before you import, please change the upstream URL to "https://github.com/RubyCrypto/ed25519" as a group rename seems to have happened (crypto-rb -> RubyCrypto).

Note that we will probably also need x25519 for rubygem-net-ssh for the full support of the ed25519 (if the net-ssh test suite is any indicator).

I'll create a PR for rubygem-net-ssh to include support for ed25519. First, we need a build of this package anyway.

LGTM. package approved!

Comment 4 Pavel Valena 2022-05-23 12:40:09 UTC

Thanks!

Comment 5 Pavel Valena 2022-09-26 13:02:25 UTC

Whoops:

Could not execute request_repo: The Bugzilla bug's review was approved over 60 days ago

Please re-approve.

_ _ _ _

Changes:
https://github.com/fedora-distgit/rubygem-ed25519/commit/ed66e5eb039bbbf272a8b3b494997e3c0f95882f

Copr build:
https://copr.fedorainfracloud.org/coprs/build/4873261

Koji scratch-build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=92350592

Checks:

  - Koji build: ok
  - Tests: ok
  - Syntax check: ok
  - Reverse dependencies: ok
  - Smoke test: ok
  - rpmlint: ok (some false positives AFAICT)

Test log: https://gist.github.com/11dc18edfe1a3081e8cbf7d37f9db506

Comment 6 Jarek Prokop 2022-09-26 13:26:40 UTC

LGTM, Approved! the contents haven't changed much.

Please remove or build the bundled Jar from sources before importing:
~~~
$ rpm -ql rubygem-ed25519-1.3.0-1.fc38.x86_64
<...>
/usr/share/gems/gems/ed25519-1.3.0/lib/ed25519_jruby.jar
<...>
~~~
(JFTR it was agreed upon removing after discussion on IRC)

Comment 7 Gwyn Ciesla 2022-09-29 13:46:33 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-ed25519

Comment 8 Pavel Valena 2022-10-17 10:19:15 UTC

Thanks once more!