Bug 1984764

Summary: cannot preserve ethtool settings
Product: Red Hat Enterprise Linux 8 Reporter: Mingyu Shi <mshi>
Component: nmstateAssignee: Gris Ge <fge>
Status: CLOSED ERRATA QA Contact: Mingyu Shi <mshi>
Severity: high Docs Contact:
Priority: high    
Version: 8.5CC: ferferna, jiji, jishi, network-qe, till
Target Milestone: betaKeywords: Triaged
Target Release: ---Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: nmstate-1.1.0-2.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-11-09 17:43:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Mingyu Shi 2021-07-22 08:03:07 UTC
Description of problem:
Changed ethtool settings, then modify the other settings of this interface(or even just touch it), the ethtool settings will get back to the default.

Version-Release number of selected component (if applicable):
nmstate-1.1.0-0.7.alpha7.el8.noarch
nispor-1.1.1-1.el8.x86_64
NetworkManager-1.32.2-1.el8.x86_64

How reproducible:
100%

Steps to Reproduce:
In here using veth to reproduce, but the issue also impacts physical NIC:

# set all ethtool.feature to false
nmstatectl apply << EOF -
interfaces:
- name: veth0
  type: veth
  state: up
  ethtool:
    feature:
      highdma: false
      rx-checksum: false
      rx-gro: false
      rx-gro-list: false
      rx-vlan-hw-parse: false
      rx-vlan-stag-hw-parse: false
      tx-checksum-ip-generic: false
      tx-checksum-sctp: false
      tx-generic-segmentation: false
      tx-gre-csum-segmentation: false
      tx-gre-segmentation: false
      tx-ipxip4-segmentation: false
      tx-ipxip6-segmentation: false
      tx-nocache-copy: false
      tx-scatter-gather-fraglist: false
      tx-sctp-segmentation: false
      tx-tcp-ecn-segmentation: false
      tx-tcp-mangleid-segmentation: false
      tx-tcp-segmentation: false
      tx-tcp6-segmentation: false
      tx-udp_tnl-csum-segmentation: false
      tx-udp_tnl-segmentation: false
      tx-vlan-hw-insert: false
      tx-vlan-stag-hw-insert: false
  veth:
    peer: veth0_p
EOF
nmstatectl show veth0 # all ethtool.feature are "false"
nmstatectl apply << EOF -
interfaces:
- name: veth0
  type: veth
  state: up
EOF
nmstatectl show veth0

Actual results:
some ethtool.feature change back to "true"

Expected results:
Preserved ethtool settings

Additional info:

Comment 1 Fernando F. Mancera 2021-07-22 12:40:00 UTC
Upstream patch: https://github.com/nmstate/nmstate/commit/13da783fe133755420874abde10f5a82105e42e5

Comment 5 Mingyu Shi 2021-08-11 12:11:05 UTC
Verified with versions:
nmstate-1.1.0-3.el8.noarch
nispor-1.1.1-1.el8.x86_64
NetworkManager-1.32.4-1.el8.x86_64

Changed ethtool settings, then reapply, change mtu etc, ethtool settings preserve.

Comment 7 errata-xmlrpc 2021-11-09 17:43:51 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (nmstate bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4157