Bug 1985256

Summary:	[machines] bus type is not correct when adding a disk
Product:	Red Hat Enterprise Linux 8	Reporter:	YunmingYang <yunyang>
Component:	cockpit-appstream	Assignee:	Katerina Koukiou <kkoukiou>
Status:	NEW ---	QA Contact:	YunmingYang <yunyang>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	8.5	CC:	mmarusak, mpitt, xchen
Target Milestone:	beta	Keywords:	Reopened, Triaged
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-08-16 07:28:33 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description YunmingYang 2021-07-23 09:08:52 UTC

Description of problem:
When adding disk with "Custom path" for a VM(bus type of system disk is 'ide'), then select "Device" to "CD/DVD disc" and  select back to "Disk image file", at this time, click "Show additional options", "Bus" will be "sata". Then, click "Add", the bus of new added disk is "ide"


Version-Release number of selected components (if applicable):
cockpit-machines-249-1.el8.noarch
cockpit-249-1.el8.x86_64
libvirt-dbus-1.3.0-2.module+el8.3.0+6423+e4cb6418.x86_64

How reproducible:
100%


Steps to Reproduce:
1 Import a VM with "Unknown" for its "Operating system"
2 Go to the VM detail page, then click "Add disk"
3 Switch "Source" to "Custom path"
4 Select "Device" to "CD/DVD disc"
5 Select "Device" to "Disk image file"
6 Click "Show additional options", then input Custom path
7 Click "Add"

Actual results:
1 After step 6, bus of "additional options" is "sata"
2 After step 7, the disk will be added successfully, but its bus is "ide"

Expected results:
1 After step 7, The bus will be added successfully, and its bus is "sata"

Additional info:

Comment 1 Katerina Koukiou 2021-07-30 13:56:00 UTC

Upstream PR https://github.com/cockpit-project/cockpit-machines/pull/296

Comment 4 YunmingYang 2021-08-25 14:09:13 UTC

Test Versions:
cockpit-machines-251-1.el8.noarch
cockpit-251-1.el8.x86_64
libvirt-dbus-1.3.0-2.module+el8.3.0+6423+e4cb6418.x86_64


Test Steps:
1 Import a VM with "Unknown" for its "Operating system"
2 Go to the VM detail page, then click "Add disk"
3 Switch "Source" to "Custom path"
4 Select "Device" to "CD/DVD disc"
5 Select "Device" to "Disk image file"
6 Click "Show additional options", extend "Bus"
7 Click "Add"
8 Re-open "Add disk" dialog, then select 'Source' to "Custom path"
9 Select "Device" to "CD/DVD disc", then select back to "Disk image file", after that select "Device" to "CD/DVD disc" again
10 Click "Show additional options"
11 Click "Add"


Actual results:
1 In step 6, there is a disabled option which is "ide"
2 In step 7, the disk will be added successfully, but its bus is "ide"
3 In step 10, the "Bus" of "CD/DVD disc" is "ide"
4 In step 11, the disk will be added successfully, but its bus is "ide"


Expected results:
1 In step 6, there is no 'ide' option
2 In step 7, the disk should be added successfully, and its bus should not be "ide"
3 In step 10, the "Bus" of "CD/DVD disc" should no be "ide"
4 In step 11, the disk should be added successfullym and its bus should not be "ide"


Additional info:
I think this BZ caused by "custom path" getting bus value from the same type disks of the VM. Maybe we should disable this behavior, and just setState()


Test Results:
According to the results, there still something needed to be fixed, move 'Status' back to ASSIGNED.

Comment 6 Martin Pitt 2021-08-30 03:49:29 UTC

Moving to 8.6.

Comment 14 RHEL Program Management 2023-01-23 07:27:46 UTC

After evaluating this issue, there are no plans to address it further or fix it in an upcoming release.  Therefore, it is being closed.  If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened.

Comment 17 RHEL Program Management 2023-08-16 07:28:33 UTC

After evaluating this issue, there are no plans to address it further or fix it in an upcoming release.  Therefore, it is being closed.  If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened.