Bug 1985474
Summary: | foreman-proxy keeps holding delete log files after rotation | ||
---|---|---|---|
Product: | Red Hat Satellite | Reporter: | Joniel Pasqualetto <jpasqual> |
Component: | Logging | Assignee: | Lukas Zapletal <lzap> |
Status: | CLOSED WONTFIX | QA Contact: | Satellite QE Team <sat-qe-bz-list> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | 6.9.0 | CC: | aruzicka, ekohlvan, lstejska |
Target Milestone: | Unspecified | Keywords: | Triaged |
Target Release: | Unused | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2023-04-06 17:10:05 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Joniel Pasqualetto
2021-07-23 16:20:48 UTC
Hey, can you give me: rpm -qa | grep rubygem-logging output? This has been identified and fixed upstream and new Ruby library logging was released 2.3.0 which includes the fix. Note Satellite 6.8 still contains the old version 2.2 with the bug. Satellite 6.9 contains 2.3.0 which is supposed to be fixed. One idea, copying is a slow operation and logrotate might compress the file too early, the process does not guarantee that the rotate operation is done any fast manner. Please specify delaycompress argument to logrotate and restart, then test it and get back to me. For more context, on your instance I see that file_rolling_size is set to the default value (0) which means smart proxy rotation is turned off completely and everything is handled by logrotate. Its configuration is: /var/log/foreman-proxy/proxy.log { missingok notifempty create 0644 foreman-proxy foreman-proxy sharedscripts rotate 5 compress daily postrotate /bin/systemctl kill --signal=SIGUSR1 foreman-proxy >/dev/null 2>&1 || true endscript } After my second though, I do not thing delaycompress would solve the problem. I think we need to use copytruncate instead, this will make sure the original never gets renamed and smart proxy can continue writing to it without reopening. Here is my insight into the problem: https://community.theforeman.org/t/foreman-proxy-open-fd-of-deleted-log-files-hdd-out-of-space/14481 Hi, is there any update on the proposed fix, can we close the BZ? Upon review of our valid but aging backlog the Satellite Team has concluded that this Bugzilla does not meet the criteria for a resolution in the near term, and are planning to close in a month. This message may be a repeat of a previous update and the bug is again being considered to be closed. If you have any concerns about this, please contact your Red Hat Account team. Thank you. Adam: You've proposed to move to journald logging by default. That would solve this bug, correct? Is there a BZ we should refer to? So far I've only proposed that in upstream community forum, as far as I know there is no issue yet that would track this anywhere. And yes, it would solve this bug Opened BZ #2168516 to track the switch to journald. Hi Adam, Does bug 2168516 replace this one? If so, should we close:dupe this one? Thanks! Upon review of our valid but aging backlog the Satellite Team has concluded that this Bugzilla does not meet the criteria for a resolution in the near term, and are planning to close in a month. This message may be a repeat of a previous update and the bug is again being considered to be closed. If you have any concerns about this, please contact your Red Hat Account team. Thank you. I'd be a little hesitant to close this as a dupe. This BZ describes an issue, the other BZ proposes changes which would, among other things, resolve the issue described here. The other BZ was never intended as a fix for this one primarily. While the other BZ should completely rule out the kind of issues similar to what is described here, I'd still rather keep both open to have this one verified on its own. Thank you for your interest in Red Hat Satellite. We have evaluated this request, and while we recognize that it is a valid request, we do not expect this to be implemented in the product in the foreseeable future. This is due to other priorities for the product, and not a reflection on the request itself. We are therefore closing this out as WONTFIX. If you have any concerns about this feel free to contact your Red Hat Account Team. Thank you. |