Bug 1985773

Summary: ptp4l crash when BC is configured
Product: OpenShift Container Platform Reporter: Sebastian Scheinkman <sscheink>
Component: NetworkingAssignee: Joseph Richard <josricha>
Networking sub component: ptp QA Contact: elevin
Status: CLOSED ERRATA Docs Contact:
Severity: high    
Priority: unspecified CC: bbennett, elevin, huirwang, keyoung, zzhao
Version: 4.9   
Target Milestone: ---   
Target Release: 4.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-10-18 17:41:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Sebastian Scheinkman 2021-07-25 16:04:27 UTC
When we apply a policy with ptp4lConf with multiple interfaces and the interface section in the toml file are after the `[global]` the ptp4l will not start with the following error:

ptp4l cmd: /usr/sbin/ptp4l -f /var/run/ptp4l.0.config  -2 --summary_interval -4 -m
unknown option uds_address at line 109 in ens1f1 section
failed to parse configuration file /var/run/ptp4l.0.config

if we move the interfaces before the global section it will work.

we should support any order in the ptpConf.

non working example:

```
       
        [global]
        #
        # Default Data Set
        #
        twoStepFlag		1
        #slaveOnly		1
        priority1		128
        priority2		128
        domainNumber		24
        #utc_offset		37
        clockClass		248
        clockAccuracy		0xFE
        offsetScaledLogVariance	0xFFFF
        free_running		0
        freq_est_interval	1
        dscp_event		0
        dscp_general		0
        dataset_comparison	G.8275.x
        G.8275.defaultDS.localPriority	128
        #
        # Port Data Set
        #
        logAnnounceInterval	-3
        logSyncInterval		-4
        logMinDelayReqInterval	-4
        logMinPdelayReqInterval	-4
        announceReceiptTimeout	3
        syncReceiptTimeout	0
        delayAsymmetry		0
        fault_reset_interval	4
        neighborPropDelayThresh	20000000
        masterOnly		0
        G.8275.portDS.localPriority	128
        #
        # Run time options
        #
        assume_two_step		0
        logging_level		6
        path_trace_enabled	0
        follow_up_info		0
        hybrid_e2e		0
        inhibit_multicast_service	0
        net_sync_monitor	0
        tc_spanning_tree	0
        tx_timestamp_timeout	100
        #was 1 (default !)
        unicast_listen		0
        unicast_master_table	0
        unicast_req_duration	3600
        use_syslog		1
        verbose			0
        summary_interval	-4
        kernel_leap		1
        check_fup_sync		0
        #
        # Servo Options
        #
        pi_proportional_const	0.0
        pi_integral_const	0.0
        pi_proportional_scale	0.0
        pi_proportional_exponent	-0.3
        pi_proportional_norm_max	0.7
        pi_integral_scale	0.0
        pi_integral_exponent	0.4
        pi_integral_norm_max	0.3
        step_threshold		0.0
        first_step_threshold	0.00002
        max_frequency		900000000
        clock_servo		pi
        sanity_freq_limit	200000000
        ntpshm_segment		0
        #
        # Transport options
        #
        transportSpecific	0x0
        ptp_dst_mac		01:1B:19:00:00:00
        p2p_dst_mac		01:80:C2:00:00:0E
        udp_ttl			1
        udp6_scope		0x0E
        uds_address		/var/run/ptp4l
        #
        # Default interface options
        #
        clock_type		OC
        network_transport	UDPv4
        delay_mechanism		E2E
        time_stamping		hardware
        tsproc_mode		filter
        delay_filter		moving_median
        delay_filter_length	10
        egressLatency		0
        ingressLatency		0
        boundary_clock_jbod	1
        #
        # Clock description
        #
        productDescription	;;
        revisionData		;;
        manufacturerIdentity	00:00:00
        userDescription		;
        timeSource		0xA0

        [ens1f0]
        masterOnly              0

```

Comment 1 zhaozhanqi 2021-08-17 09:47:12 UTC
elevin Hi, can you help verify this bug?

Comment 5 errata-xmlrpc 2021-10-18 17:41:09 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.9.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:3759

Comment 6 Red Hat Bugzilla 2023-09-15 01:12:02 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days