Bug 1986066

Summary: [rhel-9] Remove downstream-only patch to enable 'x-blockdev-reopen' once qemu is rebased to 6.1+
Product: Red Hat Enterprise Linux 9 Reporter: Peter Krempa <pkrempa>
Component: libvirtAssignee: Jiri Denemark <jdenemar>
libvirt sub component: General QA Contact: yisun
Status: CLOSED ERRATA Docs Contact:
Severity: unspecified    
Priority: unspecified CC: aliang, coli, jdenemar, virt-maint, xuzhang, yisun
Version: 9.0Keywords: Triaged
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libvirt-7.8.0-1.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-05-17 12:45:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1985452    
Bug Blocks:    

Description Peter Krempa 2021-07-26 15:41:34 UTC
Description of problem:

The following commit should no longer be forward-ported once we rebase to qemu-6.1+ which already has upstream blockdev-reopen support and the appropriate libvirt version which will have the upstream patches.

commit 44a70fb199212fcfa762979d1dfa0a7b6f6eaa34 
Author: Peter Krempa <pkrempa>
Date:   Mon Mar 16 22:12:34 2020 +0100

    RHEL: Enable usage of x-blockdev-reopen
    
    RHEL-only
    
    Introduce a new capability QEMU_CAPS_BLOCKDEV_REOPEN_COM_REDHAT_AV_8_2_0_API
    based on the presence of '__com.redhat_rhel-av-8_2_0-api' feature for
    'x-blockdev-reopen' which states that reopen works for what libvirt
    is going to use it and wire up code to call the x- prefixed command.
    
    This implementation will become dormant once qemu starts supporting
    upstream-stable blockdev-reopen.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1953939
    
    Message-Id: <098dc0e73e1b561af991f2a9ecf13436dde3b33d.1584391727.git.pkrempa>
    Reviewed-by: Ján Tomko <jtomko>

Comment 2 Han Han 2021-08-04 06:29:50 UTC
Skip pre-verification because of downstream only patches.

Comment 5 yisun 2021-10-14 07:37:03 UTC
now downstream qemu-kvm is 6.1.x so the 'blockdev-reopen' should be used
verified with following builds:
[root@dell-per730-58 qemu]# rpm -qa | egrep "qemu-kvm-6|^libvirt-7"
libvirt-7.8.0-1.el9.x86_64
qemu-kvm-6.1.0-5.el9.x86_64

[root@dell-per730-58 ~]# virsh checkpoint-create-as vm1 c1
Domain checkpoint c1 created

[root@dell-per730-58 ~]# qemu-img create -f qcow2 /var/lib/libvirt/images/jeos-27-x86_64.s1 10G
Formatting '/var/lib/libvirt/images/jeos-27-x86_64.s1', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=10737418240 lazy_refcounts=off refcount_bits=16

[root@dell-per730-58 ~]# virsh snapshot-create-as vm1 s1 --no-metadata --disk-only --reuse-external
Domain snapshot s1 created

[root@dell-per730-58 ~]# virsh checkpoint-delete vm1 c1
Domain checkpoint c1 deleted

[root@dell-per730-58 ~]# cat /var/log/libvirtd-debug.log | grep reopen | grep RECV | grep reopen | wc -l
2

[root@dell-per730-58 ~]# cat /var/log/libvirtd-debug.log | grep reopen | grep RECV | grep reopen | grep -e x-blockdev-reopen| wc -l
0

Comment 9 errata-xmlrpc 2022-05-17 12:45:04 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: libvirt), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:2390