Bug 1986386
| Summary: | Improve error message when converting to rhv using the wrong data domain name which has a specific character | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 9 | Reporter: | zhoujunqin <juzhou> |
| Component: | virt-v2v | Assignee: | Richard W.M. Jones <rjones> |
| Status: | CLOSED ERRATA | QA Contact: | Vera <vwu> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | unspecified | CC: | chhu, ehadley, lersek, mxie, rjones, tyan, tzheng, vwu, xiaodwan |
| Target Milestone: | rc | Keywords: | Triaged |
| Target Release: | --- | Flags: | pm-rhel:
mirror+
|
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | V2V_RHV_INT | ||
| Fixed In Version: | virt-v2v-2.3.4-1.el9 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-11-07 08:28:57 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
zhoujunqin
2021-07-27 12:29:49 UTC
Nir Soffer wrote: > > Traceback (most recent call last): > > File "/tmp/v2v.bTPSGc/rhv-upload-precheck.py", line 85, in <module> > > storage_domain = [sd for sd in storage_domains if sd.name == params > > ['output_storage']][0] > > IndexError: list index out of range This is not a proper way to check the response. We need to check this case and fail with good error message about missing storage domain, similar to how we handle missing host: https://github.com/libguestfs/virt-v2v/blob/0486dbe7348dc5835f4c06e6535c56ca2fe8 f38c/v2v/rhv-upload-plugin.py#L434 But the issue seems to be here: https://github.com/libguestfs/virt-v2v/blob/0486dbe7348dc5835f4c06e6535c56ca2fe8 f38c/v2v/rhv-upload-precheck.py#L62 We do a search using: search='storage.name=data*' This treats data* as a glob pattern, so it will match any storage domain starting with "data". I don't know where search pattern syntax is documented, but there is example code here showing how to search for storage domains: https://gerrit.ovirt.org/c/ovirt-engine-sdk/+/115896/1/sdk/examples/list_storage _domains.py Testing show that "\*" disable the * meta character: $ ./list_storage_domains.py -c engine-dev -s 'name=nfs*' [ { "name": "nfs-00", "id": "8ece2aae-5c72-4a5c-b23b-74bae65c88e1", "type": "data" }, ... ] $ ./list_storage_domains.py -c engine-dev -s 'name=nfs\*' [] So we can probably fix the search using: glob.escape(params['output_storage']) But, a storage domain name can contain only "a-z A-Z 0-9 _ -", so we can fail without calling the server if output_storage contains invalid character. Finally I don't know why we search for data center when we validate the storage domain name. Maybe this was copied from rhv-upload-plugin.py. I think we need to find the storage domain for validating the storage domain argument. Bulk update: Move RHEL-AV bugs to RHEL9. If necessary to resolve in RHEL8, then clone to the current RHEL8 release. Patch posted: https://listman.redhat.com/archives/libguestfs/2023-January/030525.html https://listman.redhat.com/archives/libguestfs/2023-January/030524.html Moving to RHEL 9.3 because the fix is risky. Verified with the versions: libvirt-9.2.0-1.el9.x86_64 libguestfs-1.50.1-3.el9.x86_64 qemu-kvm-8.0.0-1.el9.x86_64 virt-v2v-2.3.4-1.el9.x86_64 Steps: Convert the guest with the wrong os domain name. # virt-v2v -ic vpx://root.212.149/data/10.73.212.36/?no_verify=1 -o rhv-upload -of raw -os nfs_data* -oc https://dell-per740-22.lab.eng.pek2.redhat.com/ovirt-engine/api -op /v2v-ops/rhvpasswd -oo rhv-cafile=/v2v-ops/ca22.pem -oo rhv-cluster=Default3 esx8.0-opensuse42.3-x86_64 -it vddk -io vddk-libdir=/home/vddk7.0.3 -io vddk-thumbprint=D1:03:96:7E:11:3D:7C:4C:B6:50:28:1B:63:74:B5:40:5F:9D:9F:94 -ip /v2v-ops/esxpw [ 0.1] Setting up the source: -i libvirt -ic vpx://root.212.149/data/10.73.212.36/?no_verify=1 -it vddk esx8.0-opensuse42.3-x86_64 [ 1.9] Opening the source [ 7.6] Inspecting the source [ 20.5] Checking for sufficient free disk space in the guest [ 20.5] Converting openSUSE Leap 42.3 to run on KVM virt-v2v: The QEMU Guest Agent will be installed for this guest at first boot. virt-v2v: This guest has virtio drivers installed. [ 102.5] Mapping filesystem data to avoid copying unused and blank areas [ 103.1] Closing the overlay [ 103.4] Assigning disks to buses [ 103.4] Checking if the guest needs BIOS or UEFI to boot [ 103.4] Setting up the destination: -o rhv-upload -oc https://dell-per740-22.lab.eng.pek2.redhat.com/ovirt-engine/api -os nfs_data* Traceback (most recent call last): File "/tmp/v2v.YvLUMO/rhv-upload-precheck.py", line 57, in <module> raise RuntimeError("The storage domain (-os) parameter ‘%s’ is not valid" % RuntimeError: The storage domain (-os) parameter ‘nfs_data*’ is not valid virt-v2v: error: failed server prechecks, see earlier errors If reporting bugs, run virt-v2v with debugging enabled and include the complete output: virt-v2v -v -x [...] Moving to Verified:Tested. Verified again with the same versions: qemu-kvm-8.0.0-1.el9.x86_64 libvirt-9.2.0-1.el9.x86_64 virt-v2v-2.3.4-1.el9.x86_64 libguestfs-1.50.1-4.el9.x86_64 # virt-v2v -ic vpx://root.212.149/data/cluster/10.73.212.36/?no_verify=1 -o rhv-upload -of raw -os nfs_data* -oc https://dell-per740-22.lab.eng.pek2.redhat.com/ovirt-engine/api -op /v2v-ops/rhvpasswd -oo rhv-cafile=/v2v-ops/ca22.pem -oo rhv-cluster=Default3 esx8.0-rhel8.6-x86_64 -it vddk -io vddk-libdir=/home/vddk7.0.3 -io vddk-thumbprint=D1:03:96:7E:11:3D:7C:4C:B6:50:28:1B:63:74:B5:40:5F:9D:9F:94 -ip /v2v-ops/esxpw [ 0.0] Setting up the source: -i libvirt -ic vpx://root.212.149/data/cluster/10.73.212.36/?no_verify=1 -it vddk esx8.0-rhel8.6-x86_64 [ 1.8] Opening the source [ 10.7] Inspecting the source [ 29.1] Checking for sufficient free disk space in the guest [ 29.1] Converting Red Hat Enterprise Linux 8.6 (Ootpa) to run on KVM virt-v2v: The QEMU Guest Agent will be installed for this guest at first boot. virt-v2v: This guest has virtio drivers installed. [ 158.4] Mapping filesystem data to avoid copying unused and blank areas [ 159.1] Closing the overlay [ 159.4] Assigning disks to buses [ 159.4] Checking if the guest needs BIOS or UEFI to boot [ 159.4] Setting up the destination: -o rhv-upload -oc https://dell-per740-22.lab.eng.pek2.redhat.com/ovirt-engine/api -os nfs_data* Traceback (most recent call last): File "/tmp/v2v.MzzAUy/rhv-upload-precheck.py", line 57, in <module> raise RuntimeError("The storage domain (-os) parameter ‘%s’ is not valid" % RuntimeError: The storage domain (-os) parameter ‘nfs_data*’ is not valid virt-v2v: error: failed server prechecks, see earlier errors If reporting bugs, run virt-v2v with debugging enabled and include the complete output: virt-v2v -v -x [...] Marking as Verified. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (virt-v2v bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2023:6376 |