Bug 1986915

Summary: vdoimport conversion tool need to increment the default VG name used when one is not given
Product: Red Hat Enterprise Linux 8 Reporter: Corey Marthaler <cmarthal>
Component: lvm2Assignee: Zdenek Kabelac <zkabelac>
lvm2 sub component: VDO QA Contact: cluster-qe <cluster-qe>
Status: CLOSED ERRATA Docs Contact:
Severity: low    
Priority: urgent CC: agk, awalsh, heinzm, jbrassow, lmiksik, mcsontos, prajnoha, zkabelac
Version: 8.5Keywords: Triaged
Target Milestone: betaFlags: pm-rhel: mirror+
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: lvm2-2.03.12-9.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 2005003 (view as bug list) Environment:
Last Closed: 2021-11-09 19:45:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1930261, 2005003    

Description Corey Marthaler 2021-07-28 14:02:27 UTC 
Description of problem:
After converting one VDO, any other attempts will fail using the same default VG name. 

[root@hayes-03 ~]# vgs
  VG    #PV #LV #SN Attr   VSize   VFree
  vdovg   1   2   0 wz--n- 446.62g    0 

[root@hayes-03 ~]# lvs
  LV            VG    Attr       LSize   Pool          Origin Data%  Meta%  Move Log Cpy%Sync Convert
  vdolvol       vdovg vwi-a-v---  15.00g vdolvol_vpool        0.00                                   
  vdolvol_vpool vdovg dwi------- 446.62g                      1.10                                   

[root@hayes-03 ~]#  vdoimport --yes /dev/disk/by-id/scsi-36d09466083d8e100233c182924004b75-part1
Device does not exist.
Command failed.
  VG    #PV #LV #SN Attr   VSize   VFree
  vdovg   1   2   0 wz--n- 446.62g    0 
vdoimport: Cannot use already existing volume group name "vdovg".


Version-Release number of selected component (if applicable):
kernel-4.18.0-323.el8    BUILT: Wed Jul 14 12:12:22 CDT 2021
lvm2-2.03.12-5.el8    BUILT: Tue Jul 13 11:50:03 CDT 2021
lvm2-libs-2.03.12-5.el8    BUILT: Tue Jul 13 11:50:03 CDT 2021
vdo-6.2.5.65-14.el8    BUILT: Thu Jul 22 12:56:43 CDT 2021
kmod-kvdo-6.2.5.65-79.el8    BUILT: Thu Jul 22 12:59:43 CDT 2021


How reproducible:
Everytime
Comment 1 Zdenek Kabelac 2021-08-31 20:14:54 UTC 
Hidden  'vgs' & 'dmsetup' messages with upstream patch:

https://listman.redhat.com/archives/lvm-devel/2021-August/msg00044.html
Comment 5 Marian Csontos 2021-09-09 14:17:30 UTC 
Scratch build: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=39647501
Repo: http://brew-task-repos.usersys.redhat.com/repos/scratch/mcsontos/lvm2/2.03.12/9.el8/
Comment 6 Corey Marthaler 2021-09-14 19:25:30 UTC 
Fixed verified in the lastest scratch build.

kernel-4.18.0-340.el8    BUILT: Thu Sep  2 16:16:14 CDT 2021
lvm2-2.03.12-9.el8    BUILT: Tue Sep 14 09:53:56 CDT 2021
lvm2-libs-2.03.12-9.el8    BUILT: Tue Sep 14 09:53:56 CDT 2021

[root@hayes-03 ~]# vdo create --force --name lvm_import_vdo_sanity --vdoLogicalSize 500G --device /dev/sdc1
Creating VDO lvm_import_vdo_sanity
      The VDO volume can address 442 GB in 221 data slabs, each 2 GB.
      It can grow to address at most 16 TB of physical storage in 8192 slabs.
      If a larger maximum size might be needed, use bigger slabs.
Starting VDO lvm_import_vdo_sanity
Starting compression on VDO lvm_import_vdo_sanity
VDO instance 56 volume is ready at /dev/mapper/lvm_import_vdo_sanity
[root@hayes-03 ~]# vgcreate vdovg /dev/sdd1
  Physical volume "/dev/sdd1" successfully created.
  Volume group "vdovg" successfully created
[root@hayes-03 ~]# vgs
  VG    #PV #LV #SN Attr   VSize   VFree  
  vdovg   1   0   0 wz--n- 446.62g 446.62g
[root@hayes-03 ~]# lvm_import_vdo --yes /dev/sdc1
Stopping VDO lvm_import_vdo_sanity
Converting VDO lvm_import_vdo_sanity
      Opening /dev/disk/by-id/scsi-36d09466083d8e100233c17f420e3882f-part1 exclusively
      Loading the VDO superblock and volume geometry
      Checking the VDO state
      Converting the UDS index
      Converting the VDO
      Conversion completed for '/dev/disk/by-id/scsi-36d09466083d8e100233c17f420e3882f-part1': VDO is now offset by 2097152 bytes
  Physical volume "/dev/sdc1" successfully created.
  Volume group "vdovg1" successfully created
  WARNING: Logical volume vdovg1/vdolvol_vpool not zeroed.
  Logical volume "vdolvol_vpool" created.
  WARNING: Converting logical volume vdovg1/vdolvol_vpool to VDO pool volume WITHOUT formating.
  WARNING: Using invalid VDO pool data MAY DESTROY YOUR DATA!
  Logical volume "vdolvol" created.
  Converted vdovg1/vdolvol_vpool to VDO pool volume and created virtual vdovg1/vdolvol VDO volume.
[root@hayes-03 ~]# lvs -a -o +devices
  LV                    VG     Attr       LSize   Pool          Origin Data%  Meta%  Move Log Cpy%Sync Convert Devices               
  vdolvol               vdovg1 vwi-a-v--- 500.00g vdolvol_vpool        0.00                                    vdolvol_vpool(0)      
  vdolvol_vpool         vdovg1 dwi------- 446.62g                      1.10                                    vdolvol_vpool_vdata(0)
  [vdolvol_vpool_vdata] vdovg1 Dwi-ao---- 446.62g                                                              /dev/sdc1(0)          
[root@hayes-03 ~]# vgs
  VG     #PV #LV #SN Attr   VSize   VFree  
  vdovg    1   0   0 wz--n- 446.62g 446.62g
  vdovg1   1   2   0 wz--n- 446.62g      0
Comment 10 Corey Marthaler 2021-09-22 20:47:29 UTC 
Marking verified in the latest rpms.

kernel-4.18.0-343.el8    BUILT: Thu Sep 16 18:25:30 CDT 2021
lvm2-2.03.12-10.el8    BUILT: Mon Sep 20 03:30:20 CDT 2021
lvm2-libs-2.03.12-10.el8    BUILT: Mon Sep 20 03:30:20 CDT 2021
vdo-6.2.5.74-14.el8    BUILT: Fri Aug 20 17:56:40 CDT 2021
kmod-kvdo-6.2.5.72-80.el8    BUILT: Fri Aug 27 10:26:23 CDT 2021



SCENARIO - [attempt_in_use_vdovg_name_lvm_import_vdo_convert]
Test the proceedure for converting a second vdo volume when the default name is already in use (1986915)
vdo create --force --name lvm_import_vdo_sanity --vdoLogicalSize 500G --device /dev/sdc1
Creating VDO lvm_import_vdo_sanity
      The VDO volume can address 442 GB in 221 data slabs, each 2 GB.
      It can grow to address at most 16 TB of physical storage in 8192 slabs.
      If a larger maximum size might be needed, use bigger slabs.
Starting VDO lvm_import_vdo_sanity
Starting compression on VDO lvm_import_vdo_sanity
VDO instance 403 volume is ready at /dev/mapper/lvm_import_vdo_sanity
vgcreate vdovg /dev/sdd1
  Physical volume "/dev/sdd1" successfully created.
  Volume group "vdovg" successfully created

lvm_import_vdo --yes /dev/disk/by-id/scsi-36d09466083d8e100233c17f420e3882f-part1
Stopping VDO lvm_import_vdo_sanity
Converting VDO lvm_import_vdo_sanity
      Opening /dev/disk/by-id/scsi-36d09466083d8e100233c17f420e3882f-part1 exclusively
      Loading the VDO superblock and volume geometry
      Checking the VDO state
      Converting the UDS index
      Converting the VDO
      Conversion completed for '/dev/disk/by-id/scsi-36d09466083d8e100233c17f420e3882f-part1': VDO is now offset by 2097152 bytes
  Physical volume "/dev/disk/by-id/scsi-36d09466083d8e100233c17f420e3882f-part1" successfully created.
  Volume group "vdovg1" successfully created
  Logical volume "vdolvol_vpool" created.
  WARNING: Logical volume vdovg1/vdolvol_vpool not zeroed.
  WARNING: Converting logical volume vdovg1/vdolvol_vpool to VDO pool volume WITHOUT formating.
  WARNING: Using invalid VDO pool data MAY DESTROY YOUR DATA!
  Logical volume "vdolvol" created.
  Converted vdovg1/vdolvol_vpool to VDO pool volume and created virtual vdovg1/vdolvol VDO volume.

lvremove -f vdovg
vgremove -f vdovg
  Volume group "vdovg" successfully removed
pvremove /dev/sdd1
  Labels on physical volume "/dev/sdd1" successfully wiped.
lvmdevices -y --deldev /dev/sdd1
lvremove -f vdovg1
  Logical volume "vdolvol" successfully removed.
vgremove -f vdovg1
  Volume group "vdovg1" successfully removed
pvremove /dev/sdc1
  Labels on physical volume "/dev/sdc1" successfully wiped.
lvmdevices -y --deldev /dev/sdc1

SCENARIO - [attempt_in_use_lv_name_lvm_import_vdo_convert]
Test the proceedure for converting a vdo volume when the default lv names are already in use (1986915)
vdo create --force --name lvm_import_vdo_sanity --vdoLogicalSize 500G --device /dev/sdd1
Creating VDO lvm_import_vdo_sanity
      The VDO volume can address 442 GB in 221 data slabs, each 2 GB.
      It can grow to address at most 16 TB of physical storage in 8192 slabs.
      If a larger maximum size might be needed, use bigger slabs.
Starting VDO lvm_import_vdo_sanity
Starting compression on VDO lvm_import_vdo_sanity
VDO instance 405 volume is ready at /dev/mapper/lvm_import_vdo_sanity
vgcreate vdovg /dev/sdc1
  Physical volume "/dev/sdc1" successfully created.
  Volume group "vdovg" successfully created
lvcreate --yes -L 500M -n vdolvol_vpool vdovg
  Logical volume "vdolvol_vpool" created.
vgcreate vdovg1 /dev/sdb1
  Physical volume "/dev/sdb1" successfully created.
  Volume group "vdovg1" successfully created
lvcreate --yes -L 500M -n vdolvol vdovg1
  Logical volume "vdolvol" created.

lvm_import_vdo --yes /dev/disk/by-id/scsi-36d09466083d8e100233c17f9212bf63e-part1
Stopping VDO lvm_import_vdo_sanity
Converting VDO lvm_import_vdo_sanity
      Opening /dev/disk/by-id/scsi-36d09466083d8e100233c17f9212bf63e-part1 exclusively
      Loading the VDO superblock and volume geometry
      Checking the VDO state
      Converting the UDS index
      Converting the VDO
      Conversion completed for '/dev/disk/by-id/scsi-36d09466083d8e100233c17f9212bf63e-part1': VDO is now offset by 2097152 bytes
  Physical volume "/dev/disk/by-id/scsi-36d09466083d8e100233c17f9212bf63e-part1" successfully created.
  Volume group "vdovg2" successfully created
  Logical volume "vdolvol_vpool" created.
  WARNING: Logical volume vdovg2/vdolvol_vpool not zeroed.
  WARNING: Converting logical volume vdovg2/vdolvol_vpool to VDO pool volume WITHOUT formating.
  WARNING: Using invalid VDO pool data MAY DESTROY YOUR DATA!
  Logical volume "vdolvol" created.
  Converted vdovg2/vdolvol_vpool to VDO pool volume and created virtual vdovg2/vdolvol VDO volume.

lvremove -f vdovg2
  Logical volume "vdolvol" successfully removed.
vgremove -f vdovg2
WARNING: Heartbeat did not respond at start of command.  Check btimed service on remote host
  Volume group "vdovg2" successfully removed
pvremove /dev/sdd1
  Labels on physical volume "/dev/sdd1" successfully wiped.
lvmdevices -y --deldev /dev/sdd1
lvremove -f vdovg
  Logical volume "vdolvol_vpool" successfully removed.
vgremove -f vdovg
  Volume group "vdovg" successfully removed
pvremove /dev/sdc1
  Labels on physical volume "/dev/sdc1" successfully wiped.
lvmdevices -y --deldev /dev/sdc1
lvremove -f vdovg1
  Logical volume "vdolvol" successfully removed.
vgremove -f vdovg1
  Volume group "vdovg1" successfully removed
pvremove /dev/sdb1
  Labels on physical volume "/dev/sdb1" successfully wiped.
lvmdevices -y --deldev /dev/sdb1
Comment 12 errata-xmlrpc 2021-11-09 19:45:54 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (lvm2 bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4431