Bug 198711
| Summary: | Review Request: splint - An implementation of the lint program | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Miloslav Trmač <mitr> |
| Component: | Package Review | Assignee: | Tim Powers <timp> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 5.0 | CC: | fedora-package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 5.0.0 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-07-19 17:43:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 188273, 197183 | ||
|
Description
Miloslav Trmač
2006-07-13 01:33:02 UTC
Splint is already in Extras: $ yum list splint [...] Reading repository metadata in from local files Available Packages splint.i386 3.1.1-13.fc5 extras Yep, this request is for RHEL though. I have no idea whether f-p-r cares about that... (In reply to comment #2) > Yep, this request is for RHEL though. I have no idea whether f-p-r cares about > that... Ah. I didn't notice that part. Mea Culpa. Package looks very clean, just a comment: You obsolete lclint, but don't provide lclint. Does this package not offer the functionality of lclint? When was the last time lclint was shipped? Do we even need to worry about obsoleting something we haven't shipped in a supported upgrade release? (IE RHEL4) RPMLINT output: E: splint-debuginfo script-without-shellbang /usr/src/debug/splint-3.1.1/src/llerror.c E: splint obsolete-not-provided lclint W: splint devel-file-in-non-devel-package /usr/share/splint/lib/bool.h W: splint devel-file-in-non-devel-package /usr/share/splint/lib/linux.h W: splint devel-file-in-non-devel-package /usr/share/splint/lib/posix.h W: splint devel-file-in-non-devel-package /usr/share/splint/lib/standard.h W: splint devel-file-in-non-devel-package /usr/share/splint/lib/stdio.h W: splint devel-file-in-non-devel-package /usr/share/splint/lib/stdlib.h W: splint devel-file-in-non-devel-package /usr/share/splint/lib/unix.h W: splint incoherent-version-in-changelog 3.1.1-15 3.1.1-15.el5 Although splint is a continuation of the lclint codebase, it doesn't provide
/usr/bin/lclint and thus it is not a drop-in replacement of lclint.
lclint was last shipped in RHL 7.2 and RHEL 2.1, all RH{E,}L and Fedora splint
packages obsolete lclint. Keeping the obsoletes: should allow upgrades from
RHEL2.1 to RHEL5 - although unsupported, I think we don't need to actively
make them impossible. I don't feel strongly about it and wouldn't really mind
removing the Obsoletes:, though.
The rest of rpmlint output seems to be false positives.
The script w/out shellbang is most likely due to executable bits set on it. Fix that issue and the rest are ignorable. http://people.redhat.com/mitr/review/splint-3.1.1-16.src.rpm http://people.redhat.com/mitr/review/splint.spec Looks good now. Accepting. Tim, now in your hands. Please import this into ist CVS and then I'll create the RHEL-5 branch, add it to comps, and set up brew. Imported. - RHEL-5 branch created - added to comps - brew configured Please build your package. I am closing this bug. [jturner@porkchop 4.91]$ pwd /mnt/redhat/rel-eng/RHEL5-Server-20060919.1/4.91 [jturner@porkchop 4.91]$ find . -name "splint*" -print ./i386/os/Server/splint-3.1.1-16.el5.i386.rpm ./i386/debug/splint-debuginfo-3.1.1-16.el5.i386.rpm ./ppc/os/Server/splint-3.1.1-16.el5.ppc.rpm ./ppc/debug/splint-debuginfo-3.1.1-16.el5.ppc.rpm ./x86_64/os/Server/splint-3.1.1-16.el5.x86_64.rpm ./x86_64/debug/splint-debuginfo-3.1.1-16.el5.x86_64.rpm ./ia64/os/Server/splint-3.1.1-16.el5.ia64.rpm ./ia64/debug/splint-debuginfo-3.1.1-16.el5.ia64.rpm ./s390x/os/Server/splint-3.1.1-16.el5.s390x.rpm ./s390x/debug/splint-debuginfo-3.1.1-16.el5.s390x.rpm ./source/SRPMS/splint-3.1.1-16.el5.src.rpm |