Bug 1987192

Summary: Disabled state/condition is not consistent
Product: OpenShift Container Platform Reporter: Tomas Remes <tremes>
Component: Insights OperatorAssignee: Tomas Remes <tremes>
Status: CLOSED ERRATA QA Contact: Dmitry Misharov <dmisharo>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.9CC: aos-bugs, inecas, mklika, tremes
Target Milestone: ---   
Target Release: 4.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-10-18 17:43:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Tomas Remes 2021-07-29 07:49:28 UTC 
Description of problem:
The disabled state in IO is not consistent. There are following different behaviors:

- Removing token from pull-secret -> disabled state (by conifg) -> gathering is disabled
- Having invalid token -> disabled state (only as Operator condition -> gathering continues
- gathering failed multiple times in a row -> disabled but gathering will continue anyway


Expected results:

I think it makes sense to set the disabled state only in the first case above, because we have "uploaddegraded" state for the second case and the third case doesn't probably require an extra state at the moment since the gathering will continue (after some time) anyway.
Comment 2 Dmitry Misharov 2021-08-05 12:53:21 UTC 
Verified on 4.9.0-0.ci-2021-08-05-062416.

The Insights Operator gets disabled when the "cloud" token is removed from pull-secret.
Comment 5 errata-xmlrpc 2021-10-18 17:43:18 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.9.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:3759