Bug 1987257

Created attachment 1807043 [details]
Kibana screenshot for quay.io logs

Created attachment 1807043 [details]
Kibana screenshot for quay.io logs

Description of problem:

oc command is inconsistent with user-agent when making requests to registries for mirroring OCP4 core payload.  There was an attempt to address this with https://github.com/openshift/oc/pull/841 , but it has only caught one of the 2 registry requests which show in quay.io logs.

Attached is the screenshot for 2 log entries which are created on quay.io when oc adm mirror is run, along with the kibana json outputs for each request.

Command which I ran:

oc adm release mirror -a ${LOCAL_SECRET_JSON} \
     --from=quay.io/${PRODUCT_REPO}/${RELEASE_NAME}:${OCP_RELEASE}-${ARCHITECTURE} \
     --to=${LOCAL_REGISTRY}/${LOCAL_REPOSITORY} \
     --to-release-image=${LOCAL_REGISTRY}/${LOCAL_REPOSITORY}:${OCP_RELEASE}-${ARCHITECTURE}

Environment vars:
export OCP_RELEASE=4.8.2
export LOCAL_REGISTRY="registry.redacted.com"
export LOCAL_REPOSITORY=trees/openshift48
export PRODUCT_REPO='openshift-release-dev'
export LOCAL_SECRET_JSON='/Users/trees/tmp/secret.json'
export RELEASE_NAME="ocp-release"
export ARCHITECTURE="x86_64"


Version-Release number of selected component (if applicable):

oc 4.8.2

How reproducible:

100%


Steps to Reproduce:
1.  Run oc adm mirror per the openshift docs
2.  Verify on the logs for the container registry (quay.io) the user-agent used
3.

Actual results:

First log entry for user-agent is 'Go-http-client/2.0'
Second log entry for user-agent is 'oc/4.8.0 (darwin/amd64) kubernetes/1077b05'


Expected results:

Both log entries for user-agent is 'oc/4.8.0 (darwin/amd64) kubernetes/1077b05'