Bug 1987476

Summary: flamethrower: FTBFS in Fedora rawhide/f35
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: flamethrowerAssignee: Petr Menšík <pemensik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: dns-sig, pemensik
Target Milestone: ---Keywords: Regression
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: flamethrower-0.11.0-5.fc35 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-08-02 19:40:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1927309    
Attachments:
Description Flags
build.log
none
root.log
none
state.log none

Description Fedora Release Engineering 2021-07-29 14:58:12 UTC
flamethrower failed to build from source in Fedora rawhide/f35

https://koji.fedoraproject.org/koji/taskinfo?taskID=72346629


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild
Please fix flamethrower at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
flamethrower will be orphaned. Before branching of Fedora 36,
flamethrower will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/

Comment 1 Fedora Release Engineering 2021-07-29 14:58:17 UTC
Created attachment 1807475 [details]
build.log

Comment 2 Fedora Release Engineering 2021-07-29 14:58:20 UTC
Created attachment 1807476 [details]
root.log

file root.log too big, will only attach last 32768 bytes

Comment 3 Fedora Release Engineering 2021-07-29 14:58:22 UTC
Created attachment 1807477 [details]
state.log

Comment 4 Fedora Release Engineering 2021-08-01 04:26:19 UTC
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 35.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2021-09-23).

A week before the mass branching of Fedora 36 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 34 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-36/f-36-key-tasks.html

Comment 5 Petr Menšík 2021-08-02 12:47:49 UTC
Found we have package for catch header, which has this issue already fixed. But instead bundled header from 3rd/catch is used. The best fix would be using catch-devel package if possible, working around current build issue. Should have been declared as bundled before.

Comment 6 Petr Menšík 2021-08-02 19:40:32 UTC
I found my check of 3rd party headers/libraries on initial review was incomplete. It uses bunch of other libraries. Only catch-devel is already packaged, most of others is not. I think they should be packaged eventually and switched to using system library. Until that is done, I added bundled provides at least:

# 3rd/json from https://github.com/nlohmann/json
Provides: bundled(json.hpp) = 3.7.3
# 3rd/docopt from https://github.com/docopt/docopt.cpp
Provides: bundled(docopt.cpp)
# 3rd/url-parser from https://github.com/play-co/url-parser (?)
# subset of https://github.com/nodejs/http-parser (package exists)
Provides: bundled(url-parser)
# 3rd/uvw from https://github.com/skypjack/uvw
Provides: bundled(uvw)
# 3rd/cpp-httplib from https://github.com/yhirose/cpp-httplib
Provides: bundled(cpp-httplib)
# 3rd/base64url from https://renenyffenegger.ch/notes/development/Base64/Encoding-and-decoding-base-64-with-cpp/index
# also https://github.com/ReneNyffenegger/cpp-base64
Provides: bundled(cpp-base64)

Anyway, it builds again with catch-devel used instead of bundled one. Upstream already accepted the change.